GNOME Bugzilla – Bug 163770
Fix some warnings generated from wncklet applet
Last modified: 2005-02-02 09:12:57 UTC
While trying to debug bug 163343, I ran across some related critical warnings from libwnck (bug 149326). So, I started running with --g-fatal-warnings. When I did so, I also got two more crashes from wncklet that didn't appear to come from libwnck. I'll attach a patch in a minute that avoids these warnings/errors/whatever.
Created attachment 35882 [details] [review] Check for window_menu being NULL
Elijah: how can window_menu be NULL in these functions?
I don't know. I just know they were. (It was the first time I ever looked at the wncklet code, and I didn't bother to investigate very far since I was really concentrating on a different problem and was trying to get back to it...) Would you like me to try to get a stack trace from the crashes I saw with --g-fatal-warnings where they were NULL?
Oh, and in case you want to try to reproduce, here are the circumstances under which I saw the two different crashes after running with --g-fatal-warnings: Case 1: Start switching tabs in a gnome-terminal or in mozilla. Case 2: Go to an workspace with no windows, and open up a terminal.
Elijah: it'd be great if you can get some stack traces! I'm looking at something else right now, but I'll try to look at this later. Thanks
I can't reproduce at school--I'm suspecting I may messed up something on my home system. Let me take a look...
Created attachment 35923 [details] One of the stack traces....
Created attachment 35924 [details] A new one not fixed by the patch
Okay, so although I can still repeat this even after updating gnome-menus and gnome-panel, I think it really just points to something being haywire on my home machine. In particular, from the new stack trace:
+ Trace 54450
This makes absolutely no sense. How can window_menu be non-NULL in window_menu_set_active_window, get passed to window_menu_set_window_icon, and then suddenly be NULL? Something has got to be wrong on this machine, though I have no clue what it would be...
Comment on attachment 35882 [details] [review] Check for window_menu being NULL Patch doesn't look ok (see previous comments)
2005-02-02 Vincent Untz <vincent@vuntz.net> * libwnck/selector.c: fix typo (wnck_selector_window_icon_changed): (wnck_selector_window_name_changed): (wnck_selector_window_state_changed): (wnck_selector_window_closed): don't do anything if the hash was not created yet Fix bug #163770