After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 162913 - [mms] missing NULL terminator to g_object_set() in uri handler
[mms] missing NULL terminator to g_object_set() in uri handler
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal blocker
: 0.8.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-01-04 13:11 UTC by Tim-Philipp Müller
Modified: 2005-01-05 00:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (479 bytes, patch)
2005-01-04 13:13 UTC, Tim-Philipp Müller
none Details | Review

Description Tim-Philipp Müller 2005-01-04 13:11:57 UTC
There's a potential crash in gst_mms_uri_set_uri(), caused by a missing NULL 
terminator. 
 
Patch attached. 
 
Cheers 
 -Tim
Comment 1 Tim-Philipp Müller 2005-01-04 13:13:16 UTC
Created attachment 35427 [details] [review]
patch
Comment 2 Ronald Bultje 2005-01-04 13:45:00 UTC
Definately needs to go in, since it'll cause crashers, is easy to fix and is one
of our new features in this release.
Comment 3 Stephane Loeuillet 2005-01-04 13:46:34 UTC
i have that each time i try to play some mms:// URI, is it related to this bug ?

(totem:2252): GLib-CRITICAL **: g_str_has_prefix: assertion `str != NULL' failed

if yes, cdda:// needs a similar fix
Comment 4 Thomas Vander Stichele 2005-01-04 14:03:07 UTC
commited, closing this bug.

Stephane, could you open a separate one for cdda:// with a backtrace ? Use
--gst-fatal-warnings
Comment 5 Tim-Philipp Müller 2005-01-04 16:00:50 UTC
I've created bug #162924 for the assertion failures (incl. patch). 
 
Cheers 
 -Tim 
 
Comment 6 Maciej Katafiasz 2005-01-05 00:26:54 UTC
Aaah, I suspected something simple, stupid /me :). Thanks for patch