GNOME Bugzilla – Bug 162750
[RFE] Icons for CD burner menuitem and window, Computer window, Trash menuitems and chang
Last modified: 2005-01-11 12:15:57 UTC
Now: * The CD burner menuitem does not have an icon and the window just has a folder icon. * The computer window has a folder icon. * Trash menuitem has no icon After patch: They have an appropriate icon
Created attachment 35368 [details] [review] The patch Only weird thing is that the trash icon looks a bit funny in the menu. The trash can (at least with the default gnome icons) seems a bit to slim, when you compare it with the icon on the desktop. It looks like that not both axis are scaled with the same amount (next attachment shows this). It is I guess also caused by the fact that the 48x48 trash icon is actually 58x44 (Anybody knows why???) I think that the wrong scaling is not caused by my patch or nautilus but somewhere in GTK, where the gtkactionentries are assigned to the menus. But I got a bit lost when looking for the place where this happened. (I'm relatively new to gnome programming) leaving out the trash can could also be an option.
Created attachment 35369 [details] screenshot showing weirdly scaled trash menu item
Some of these changes duplicate those in the patch attached to bug 149941.
Created attachment 35374 [details] [review] Proposed patch. This proposed patch merges the menu item fixes from bug report 149941 with the previously attached patch. The merged patch adds the following bug fixes. 1. There are a few mnemonic conflicts. In the Places menu, Trash and Templates both use 'T'; Computer and CD Creator both use 'C'. In the Go menu, Trash and Templates both use 'T'; Computer, CD Creator, and Clear History all use 'C'. 2. The 'CD Creator' menu item should be relabeled to 'CD/DVD Creator' to match the new name for nautilus-cd-burner. 3. I added gtk-stock icons for the Trash, Templates, and CD Creator menu items.
Hi Dennis, Nice improvements. Some comments and questions on your merged patch. 1. In the default gnome icon theme the trash icon (square blue trash can) is different then the GTK_STOCK_DELETE (round grey trash can). My patch which uses "gnome-fs-trash-empty" does not have that issue. 2. My patch uses exactly the same icon for the cd burner then the nautilus cd burner does (i.e. "gnome-dev-cdrom"). With your approach you can get the same effect as I describe in 1. 3. Do you think GTK_OPEN is the best icon for a template? I guess we'd better use stock_new-template.png instead. I suggest that we then also change the window icon of the templates folder then.
Hi Jaap, These are good questions. Regarding using stock icons, we already do this for the home icon i.e. GTK_STOCK_HOME. But, I think it's up to the nautilus maintainers to decide.
Created attachment 35409 [details] [review] Added menu item changes Hi Dennis, Reading your patch noticed that in your patch you change the access keys of items which are already unique. Reading your comments in comment 4 and looking at your original patch http://bugzilla.gnome.org/attachment.cgi?id=30451&action=view I notice that in the mean time the non unique access keys (mnemonics) of Templates and Trash were already changed. I don't think these should be changed again. Only the CD Creator, Computer and Clear History still have the same access key. I now changed this in my patch by changing "CD _Creator" to "CD/_DVD Creator". I opted for changing _Clear History into Clea_r History instead of changing _Computer because Clear History is not part of the Go menu in the spatial mode and Computer is probably also used more then Clear History. Concerning the icons I think it's not a good idea to use different icons for the menu items and the windows. It does not seem logical to me. Thinking along that line the home icon should change to the folder with the home symbol. (Or the other way around, but the first has my personal esthetical preference) I tried out using stock_new-template.png for templates. But that does not look really pleasing to the eye and you can't see it's a template because the icon is getting to small. Other option could be to use GTK_STOCK_NEW but I don't like the result of that too much either. The best would be to have a GTK_STOCK_TEMPLATE icon or an icon which looks like a folder but with a template symbol (what ever that may be) on it, but that doesn' exist (yet). But concerning your comments that the maintainers in the end decide I agree fully, and giving them multiple options to choose from will only make the end result better.
The reason that stock_new-template.png does not display seems to bethat the hicolor gnome theme does not work well in nautilus See: http://mail.gnome.org/archives/nautilus-list/2005-January/msg00005.html If that gets fixed I think stock_new-template.png is the best option for the templates dir.
BTW if we were to use a stock item for the templates menu, we could use GTK_STOCK_DIRECTORY for templates. This is a new stock item in Gtk+ 2.6.
All right, i commited something based on the last patch using stock_new-template.png for templates. I also fixed the stock icon code to register icons for all sizes, which fixed the resize issue.