GNOME Bugzilla – Bug 162185
[PATCH] gnome-sound-recorder cannot properly save files across file systems
Last modified: 2005-01-27 23:13:36 UTC
Gnome-sound-recorder's save interface has a few big problems. First, it uses the rename syscall to move the temporary working file to a final persistent destination. However, on FreeBSD the default temp directory is /var/tmp (on the /var file system), and most users will save to their home directory (on the /usr or /home file systems). The rename syscall does not work across file systems. The second problem with saving files is that g-s-r doesn't update its window to indicate the file was saved successfully. The attached patch corrects both problems. You might want to clean it up a bit to perhaps add a callback to gnome_vfs_xfer_uri() to give the user some feedback while the save is happening. I basically used the options to gnome_vfs_xfer_uri() that most closely emulate what rename() was trying to do.
Created attachment 35194 [details] [review] Fix save problems in g-s-r
We use a system() call in CVS, I like using gnome-vfs better. Can you re-do the patch against CVS/HEAD?
No problem. New patch is attached.
Created attachment 35204 [details] [review] Patch against HEAD to improve g-s-r save functionality
Has there been any progress in getting this patch merged? It would be really nice to get this bug fixed.
Hm, yeah, applied. :).