After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 162185 - [PATCH] gnome-sound-recorder cannot properly save files across file systems
[PATCH] gnome-sound-recorder cannot properly save files across file systems
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: Gnome-Sound-Recorder
2.8.x
Other FreeBSD
: Normal major
: 2.9.91
Assigned To: gnome media maintainers
gnome media maintainers
Depends on:
Blocks:
 
 
Reported: 2004-12-24 20:21 UTC by Joe Marcus Clarke
Modified: 2005-01-27 23:13 UTC
See Also:
GNOME target: ---
GNOME version: 2.7/2.8


Attachments
Fix save problems in g-s-r (1.62 KB, patch)
2004-12-24 20:22 UTC, Joe Marcus Clarke
none Details | Review
Patch against HEAD to improve g-s-r save functionality (2.60 KB, patch)
2004-12-26 02:25 UTC, Joe Marcus Clarke
none Details | Review

Description Joe Marcus Clarke 2004-12-24 20:21:18 UTC
Gnome-sound-recorder's save interface has a few big problems.  First, it uses
the rename syscall to move the temporary working file to a final persistent
destination.  However, on FreeBSD the default temp directory is /var/tmp (on the
/var file system), and most users will save to their home directory (on the /usr
or /home file systems).  The rename syscall does not work across file systems.

The second problem with saving files is that g-s-r doesn't update its window to
indicate the file was saved successfully.  The attached patch corrects both
problems.  You might want to clean it up a bit to perhaps add a callback to
gnome_vfs_xfer_uri() to give the user some feedback while the save is happening.
 I basically used the options to gnome_vfs_xfer_uri() that most closely emulate
what rename() was trying to do.
Comment 1 Joe Marcus Clarke 2004-12-24 20:22:18 UTC
Created attachment 35194 [details] [review]
Fix save problems in g-s-r
Comment 2 Ronald Bultje 2004-12-24 21:09:57 UTC
We use a system() call in CVS, I like using gnome-vfs better. Can you re-do the
patch against CVS/HEAD?
Comment 3 Joe Marcus Clarke 2004-12-26 02:24:39 UTC
No problem.  New patch is attached.
Comment 4 Joe Marcus Clarke 2004-12-26 02:25:33 UTC
Created attachment 35204 [details] [review]
Patch against HEAD to improve g-s-r save functionality
Comment 5 Dafydd Harries 2005-01-27 22:01:42 UTC
Has there been any progress in getting this patch merged? It would be really
nice to get this bug fixed.
Comment 6 Ronald Bultje 2005-01-27 23:13:36 UTC
Hm, yeah, applied. :).