GNOME Bugzilla – Bug 161693
move sidebar impl to ephy-embed-single ?
Last modified: 2005-01-01 21:38:16 UTC
<reinouts> chpe: I wonder, would it be nice if ephy told the user about e-e when she clicks to add a mozilla sidebar, and the sidebar extn isn't installed <reinouts> or if it is installed but not activated, offer to activate it <mpt> or just install+activate it (why else would they have clicked on it?) <chpe> reinouts: that's technically impossible: to detect that the user wants to add a sidebar, we have to implement nsISidebar interface (which the extension does), but if it's not loaded yet, it doesn't work of course<crispin> chpe, you could implement it with a signal on ephy-embed-single, which by default ephy just brings up a dialog box, the extension could then just listen for that signal, and prevent the default handler from being called <crispin> that has the advantage that those crashes wouldn't happen anymore :-) <chpe> crispin: hmm yeah that's a neat idea
Created attachment 35006 [details] [review] Patch to implement an add-sidebar signal on the embed-single If you want this, it would be simple to add a basic signal handler that would (in the core ephy) just say that epiphany doesn't itself support sidebars but tell people to go look at the e-e sidebar impl.
If this is done, it would mean that bug 157088 and bug 156849 could be fixed in the sidebar extension.
Comment on attachment 35006 [details] [review] Patch to implement an add-sidebar signal on the embed-single +EphySidebar::AddPanel (const PRUnichar *aTitle, + const char *aContentURL, + const char *aCustomizeURL) What's the aCustomizeURL parameter for?
To be honest, I have absolutely no idea what the aCustomizeURL parameter is for, certainly I can't find any documentation or uses of it on google.
The implementation has now been moved to epiphany: http://mail.gnome.org/archives/cvs-commits-list/2005-January/msg00141.html Adding a dialog in the default instance (without the extension installed) is now: http://bugzilla.gnome.org/show_bug.cgi?id=162685