After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 160934 - [Patch] Changing terminal command is not instanteanous
[Patch] Changing terminal command is not instanteanous
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
trunk
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2004-12-10 09:15 UTC by Balamurali Viswanathan
Modified: 2005-01-25 18:03 UTC
See Also:
GNOME target: ---
GNOME version: 2.7/2.8

Attachments
Patch for this problem (1.53 KB, patch)
2004-12-10 09:17 UTC, Balamurali Viswanathan 		none Details | Review
Updated patch for this problem (1.56 KB, patch)
2004-12-13 05:19 UTC, Balamurali Viswanathan 		accepted-commit_now Details | Review

Description Balamurali Viswanathan 2004-12-10 09:15:13 UTC 
1. Assign a shortcut key to run terminal from (gnome-keybinding-properties)
keyboard shortcut capplet (say ctrl +r)
2. clicking on ctrl+r starts gnome-terminal
3. Open gconf-editor and go to /desktop/gnome/applications/terminal and change
the command to "xterm" from "gnome-terminal"
4. clicking on ctrl+r still starts gnome-terminal instead of xterm

Attached a  small patch which solves this problem. Thanks
Comment 1 Balamurali Viswanathan 2004-12-10 09:17:55 UTC 
Created attachment 34687 [details] [review]
Patch for this problem
Comment 2 Havoc Pennington 2004-12-12 20:34:55 UTC 
You are missing a cleanup_err() call there - what if you get an error from the
add_dir() before this one.

Otherwise the patch looks good, thanks.
Comment 3 Balamurali Viswanathan 2004-12-13 05:19:59 UTC 
Created attachment 34786 [details] [review]
Updated patch for this problem

Thanks for the comments Havoc. Attaching an updated patch with the above
comment. Thanks.
Comment 4 Elijah Newren 2005-01-24 21:33:17 UTC 
Havoc: okay to commit?
Comment 5 Elijah Newren 2005-01-25 18:03:09 UTC 
committed.