After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 160723 - New Launcher Backend & Tile
New Launcher Backend & Tile
Status: RESOLVED FIXED
Product: beagle
Classification: Other
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Beagle Bugs
Beagle Bugs
Depends on:
Blocks:
 
 
Reported: 2004-12-07 19:20 UTC by Joe Gasiorek
Modified: 2005-01-13 00:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Beagle Launcher Patch (11.13 KB, patch)
2004-12-07 19:20 UTC, Joe Gasiorek
none Details | Review
Beagle Launcher Screenshot (66.35 KB, image/png)
2004-12-07 19:21 UTC, Joe Gasiorek
  Details
Updated Launcher Patch (12.08 KB, patch)
2004-12-09 17:47 UTC, Joe Gasiorek
none Details | Review

Description Joe Gasiorek 2004-12-07 19:20:08 UTC
I mostly brought this back to test the new SQlite code, not sure if it is still
wanted.  Will attach patch (against CVS) and screenshot.
Comment 1 Joe Gasiorek 2004-12-07 19:20:42 UTC
Created attachment 34608 [details] [review]
Beagle Launcher Patch
Comment 2 Joe Gasiorek 2004-12-07 19:21:28 UTC
Created attachment 34609 [details]
Beagle Launcher Screenshot
Comment 3 Joe Shaw 2004-12-08 20:58:13 UTC
Basic patch looks good.  There are a few changes needed before it can go in, though:

* Invoking pkg-config from inside the backend is really gross.  It'd be much
better if it were done at configure-time.  Bonus points for also checking where
KDE is installed and using those paths.  Look at
beagled/ExternalStringsHack.cs.in to see the basics on how to do this.

* Since you're just doing one string concatenation for each directory, there's
no need to create a StringBuilder.  You can just do:

   Dirs.Add (fullpath.ToString () + "applications/");

and then deal with just strings.  If there were a lot more using a StringBuilder
would be more advantageous.
Comment 4 Joe Gasiorek 2004-12-09 17:47:28 UTC
Created attachment 34670 [details] [review]
Updated Launcher Patch

This patch contains fix's for the StringBuilder and pkg-config problems that
Joe mentioned.	KDE support will have to wait till I can figure out how to find
the KDE icons.

Patch works against CVS.
Comment 5 Joe Shaw 2005-01-12 20:26:49 UTC
sorry for the delay, this looks good to commit.