GNOME Bugzilla – Bug 157997
g_object_unref: assertion `object->ref_count > 0' failed
Last modified: 2004-12-22 21:47:04 UTC
wget http://www.grc.nasa.gov/WWW/AcousticalTest/Xls/Mnew1.xls ./gnumeric Mnew1.xls Reading file:///home/welinder/private/gnome/gnumeric/src/Mnew1.xls Excel 95 (gnumeric:10493): GLib-GObject-CRITICAL **: g_object_unref: assertion `object->ref_count > 0' failed (gnumeric:10493): GLib-GObject-CRITICAL **: g_object_unref: assertion `object->ref_count > 0' failed (gnumeric:10493): GLib-GObject-CRITICAL **: g_object_unref: assertion `object->ref_count > 0' failed ** (gnumeric:10493): WARNING **: failed to read prop #6 ** (gnumeric:10493): WARNING **: GnomePrint: Requested Arial Narrow but using Sans (Sans Regular 18.000000) ** (gnumeric:10493): WARNING **: Trying to fallback to 'Arial'
Amazingly, there are no purify events. (gdb) where
+ Trace 51858
$2 = {parent_object = {g_type_instance = {g_class = 0x4e93a0}, ref_count = 0, qdata = 0x0}, sheet = 0x0, realized_list = 0x0, anchor = {cell_bound = {start = {col = 0, row = 0}, end = {col = 0, row = 4}}, offset = {0, 0, 0.98828125, 0.09375}, type = {SO_ANCHOR_PERCENTAGE_FROM_COLROW_START, SO_ANCHOR_PERCENTAGE_FROM_COLROW_START, SO_ANCHOR_PERCENTAGE_FROM_COLROW_START, SO_ANCHOR_PERCENTAGE_FROM_COLROW_START}, direction = SO_DIR_DOWN_RIGHT}, flags = 196611}
I can reproduce. Testing a patch now.
Created attachment 33754 [details] [review] clean up image life cycle, and delay view creation for all sheet objects This is really two patches. 1) to clean up the excel importer 2) a cheat to delay the creation of views until after we load blips. It seems like a decent performance win too. Patch seems to work for the std test images, but does not load thes images in this bugs test file. That will require some tweaking to get the data from a pixbuf -> SheetObjectImage. Thoughts ?
release is close. This needs review.
A bit complicated for this point in time. I'd say we just remove the offending unref for now.
There were problems with the patch. I'll attach an updated version for after the release, and do a variant of the unref for now. That seems safest.
Comment on attachment 33754 [details] [review] clean up image life cycle, and delay view creation for all sheet objects The delayed view creation would be a nice touch, but caused problems with object creation. The scg assumes that setting the sheet makes a view available.
Created attachment 33790 [details] [review] don't set the sheet until after al the props are set. This seems reasonable, but causes a few problems with dependents wen setting expressions.
Comment on attachment 33790 [details] [review] don't set the sheet until after al the props are set. applied to CVS for 1.4.2