After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 157401 - PATCH: MSVC demo build fixes, new .cvsignore files
PATCH: MSVC demo build fixes, new .cvsignore files
Status: RESOLVED FIXED
Product: gtkmm
Classification: Bindings
Component: build
2.4
Other Windows
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2004-11-04 23:08 UTC by Timothy M. Shead
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixes MSVC compile-time errors in demo applications (7.59 KB, patch)
2004-11-04 23:08 UTC, Timothy M. Shead
none Details | Review
New .cvsignore files for the MSVC_Net2003 directory (843 bytes, application/x-tar)
2004-11-04 23:09 UTC, Timothy M. Shead
  Details

Description Timothy M. Shead 2004-11-04 23:08:14 UTC
Fixes compile-time errors with MSVC .Net 2003 in the gtk-demo, stock, and
tictactoe examples.

Adds new .cvsignore files for the MSVC_Net2003 directory.
Comment 1 Timothy M. Shead 2004-11-04 23:08:53 UTC
Created attachment 33448 [details] [review]
Fixes MSVC compile-time errors in demo applications
Comment 2 Timothy M. Shead 2004-11-04 23:09:22 UTC
Created attachment 33449 [details]
New .cvsignore files for the MSVC_Net2003 directory
Comment 3 Cedric Gustin 2004-11-05 08:15:11 UTC
Thanks.

Next time, could you please mention that your .cvsignore attachment was in fact
a .tar.gz ?
Comment 4 Murray Cumming 2004-11-05 10:51:55 UTC
Thanks. The patch looks OK to me, apart from this part:

- type_slotDo slot = row[columns.slot];
+ type_slotDo slot = row.get_value(columns.slot);

That really should work. Please put it in an #ifdef for now if it doesn't, but
show us the compile error.

I leave it to Cedric to actually apply win32 stuff.

Comment 5 Murray Cumming 2004-11-10 19:09:19 UTC
Cedric, will you apply this?
Comment 6 Cedric Gustin 2004-11-11 12:03:32 UTC
I committed all .cvsignore files to the gtkmm-2-4 branch

For the 'type_slotDo slot = row[columns.slot]' issue, the error returned by MSVC is

c:\Users\Gustin\Programs\libsigc++2\sigc++\functors\slot.h(103) : error C2440:
'return' : cannot convert from 'sigc::adaptor_functor::result_type' to
'Gtk::Window *'
        with
        [
            T_functor=sigc::adaptor_trait>::functor_type
        ]
        Expressions of type void cannot be converted to other types
        c:\Users\Gustin\Programs\libsigc++2\sigc++\functors\slot.h(100) : while
compiling class-template member function 'Gtk::Window
sigc::internal::slot_call0::call_it(sigc::internal::slot_rep *)'
        with
        [
            T_functor=Gtk::TreeValueProxy,
            T_return=Gtk::Window *
        ]
        c:\Users\Gustin\Programs\libsigc++2\sigc++\functors\slot.h(452) : see
reference to class template instantiation 'sigc::internal::slot_call0' being
compiled
        with
        [
            T_functor=Gtk::TreeValueProxy,
            T_return=Gtk::Window *
        ]
        c:\Users\Gustin\Programs\libsigc++2\sigc++\functors\slot.h(1103) : see
reference to function template instantiation 'sigc::slot0::slot0(const T_functor
&)' being compiled
        with
        [
            T_return=Gtk::Window *,
            T_functor=Gtk::TreeValueProxy
        ]
        c:\Users\Gustin\Programs\gtkmm\demos\gtk-demo\demowindow.cc(162) : see
reference to function template instantiation 'sigc::slot::slot>(const T_functor
&)' being compiled
        with
        [
            T_return=Gtk::Window *,
            ColumnType=type_slotDo,
            T_functor=Gtk::TreeValueProxy
        ]

A few days ago, I committed an updated demowindow.cc with

const type_slotDo& slot = row[columns.slot];

that does the job.