After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 156851 - [PATCH] Crash on startup on 64-bit architectures, and other 64-bit cleanliness issues
[PATCH] Crash on startup on 64-bit architectures, and other 64-bit cleanlines...
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
unspecified
Other Linux
: Normal major
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2004-10-29 19:46 UTC by Dave Malcolm
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix crash bugs in the various get_type functions (4.31 KB, patch)
2004-10-29 19:47 UTC, Dave Malcolm 		none Details | Review
Revised version of patch, which covers the libgthumb subdirectory as well as the src subdirectory (8.29 KB, patch)
2004-10-29 21:01 UTC, Dave Malcolm 		none Details | Review

Description Dave Malcolm 2004-10-29 19:46:20 UTC 
gthumb-2.4.2 contains various _get_type functions which use a guint internally
to store a GType; they should use a GType as there's no guarantee that a guint
can hold a GType (and this assumption breaks on 64-bit architectures).

Am about to attach a patch (against the 2.4.2 tarball) with a proposed fix...
Comment 1 Dave Malcolm 2004-10-29 19:47:51 UTC 
Created attachment 33218 [details] [review]
Patch to fix crash bugs in the various get_type functions
Comment 2 Dave Malcolm 2004-10-29 19:56:15 UTC 
Tracking this downstream here:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=137594
Comment 3 Paolo Bacchilega 2004-10-29 20:02:39 UTC 
patch applied to HEAD and gthumb-2-4 branches, thank you.
Comment 4 Dave Malcolm 2004-10-29 20:06:16 UTC 
Doh!  That only covered the src directory; there are more in libgthumb; I'll
attach an updated patch shortly...
Comment 5 Dave Malcolm 2004-10-29 21:01:38 UTC 
Created attachment 33222 [details] [review]
Revised version of patch, which covers the libgthumb subdirectory as well as the src subdirectory
Comment 6 Paolo Bacchilega 2004-10-30 07:10:25 UTC 
applied.