GNOME Bugzilla – Bug 155246
gnome-default-applications-properties improvements
Last modified: 2005-05-16 22:12:00 UTC
gnome-default-applications-properties misses w3m, doesn't know Mozilla Firefox by its current binary name and could be made to support some Debian specific helper apps.
Created attachment 32537 [details] [review] Proposed patch
Comment on attachment 32537 [details] [review] Proposed patch Fine Please commit. Do we want x-www-browser too ?
sensible-browser takes care of that; it's a wrapper script that tries the browser(s) in $BROWSER (if defined) and falls back to x-www-browser (if $DISPLAY is set) or x-terminal-emulator -e www-browser. I've committed the patch.
Please revert the string changes. You can add a new entry for Firefox without changing the string, but we should not be adding strings until we branch. There's also a patch to fix up other stuff in this dialog that should be applied, but adding strings days before a stable release is not the way to go.
I commited the attached patch to fix up the string changes. This should make it work better. Together with a couple of other approved patches.
Created attachment 32594 [details] [review] reworked patch
So, the original patch should go in on HEAD after branching. It probably needs tweaking to apply, and it would probably be a good idea to rework the lists to drop some old stuff etc?
control-center has branched, ok to commit the original patch changes ? Do you want extra changes ?
I took the liberty of changing things in HEAD (http://cvs.gnome.org/viewcvs/gnome-control-center/capplets/default-applications/gnome-default-applications-properties-structs.c?rev=1.12&only_with_tag=HEAD&view=log) and of fixing what I could without string changes in gnome-2-8 (http://cvs.gnome.org/viewcvs/gnome-control-center/capplets/default-applications/gnome-default-applications-properties-structs.c?only_with_tag=gnome-2-8&r2=1.11.2.1&r1=1.11). When/if string changes are allowed for gnome-2-8, the full changes from HEAD can be backported.
Note that MailReader doesn't allow Thunderbird as an option. This should probably be fixed in the same manner as Firefox above.
I've added Thunderbird to HEAD.
This dialog also doesn't list Opera and Evolution 2.0 yet. Opera's binary is called "opera", and it's launched like all the other browsers ("opera %s").
any reason to keep name1/name2 titles ? diff -u -r1.14 gnome-default-applications-properties-structs.c --- gnome-default-applications-properties-structs.c 21 Oct 2004 19:19:45 -0000 1.14 +++ gnome-default-applications-properties-structs.c 25 Nov 2004 13:25:15 -0000 @@ -10,10 +10,10 @@ { N_("Epiphany"), "epiphany", "epiphany %s", FALSE, FALSE }, { N_("Galeon"), "galeon", "galeon %s", FALSE, FALSE }, { N_("Encompass"), "encompass", "encompass %s", FALSE, FALSE }, - { N_("Firebird/FireFox"), "mozilla-firebird", "mozilla-firebird %s", FALSE, FALSE }, + { N_("Firebird"), "mozilla-firebird", "mozilla-firebird %s", FALSE, FALSE }, { N_("Firefox"), "firefox", "firefox %s", FALSE, FALSE }, - { N_("Mozilla/Netscape 6"), "mozilla-1.6", "mozilla-1.6 %s", FALSE, FALSE }, - { N_("Mozilla/Netscape 6"), "mozilla", "mozilla %s", FALSE, FALSE }, + { N_("Mozilla"), "mozilla-1.6", "mozilla-1.6 %s", FALSE, FALSE }, + { N_("Mozilla"), "mozilla", "mozilla %s", FALSE, FALSE }, { N_("Netscape Communicator"), "netscape", "netscape %s", FALSE, FALSE }, { N_("Konqueror"), "konqueror", "konqueror %s", FALSE, FALSE }, { N_("W3M Text Browser"), "w3m", "w3m %s", TRUE, FALSE }, Ok to commit this ?
seb : foo/bar names seem cleaner to me than having such a large plethora of entries. For 2.10 I think we should aim to keep this list externally
you don't get a plethora of entries on screen since only installed app are displayed ... by example having Firebird/Firefox is confusing for the users who don't even know what firebird is, and firebird will not be displayed on a system with firefox installed ...
True, I'd forgotten that we added that. patch approved.
commited. BTW what do you mean by "we should aim to keep this list externally" ? How/where do you want to store this ?
Seems like something we could stick in an xml file. gconf would be nice, but the data is too complex for the simple list implementation.
Comment on attachment 32594 [details] [review] reworked patch So can we close this bug then? Or leave it open and rename to 'move data to an external xml file'? I've taken the liberty of marking the reworked patch committed.
The other one was commited too it seems. Closing this as fixed. Please file a new bug report for the externalization of the data so we don't have to read through a whole bunch of old comments to get to the core of the issue.