After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 154441 - galeon 1.3.17 does not build on Fedora Core Devel Mozilla 1.7.3
galeon 1.3.17 does not build on Fedora Core Devel Mozilla 1.7.3
Status: RESOLVED FIXED
Product: galeon
Classification: Deprecated
Component: Mozilla interaction
1.3.17
Other Linux
: Normal major
: 1.3.18
Assigned To: Philip Langdale
Yanko Kaneti
Depends on:
Blocks:
 
 
Reported: 2004-10-04 09:53 UTC by Nicolas Mailhot
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Nicolas Mailhot 2004-10-04 09:53:23 UTC 
Probably linked to:

* mer sep 29 2004 Christopher Aillon <caillon@redhat.com> 37:1.7.3-5
- Backport the GTK+ file chooser.

 g++ -DHAVE_CONFIG_H -I. -I. -I.. -I../utils -I../utils -I../embed
-I../bookmarks -I../libegg -I.. -I/usr/include/mozilla-1.7.3/gtkembedmoz
-I/usr/include/mozilla-1.7.3 -I/usr/include/mozilla-1.7.3/xpcom
-I/usr/include/mozilla-1.7.3/string -I/usr/include/mozilla-1.7.3/nspr
-I/usr/include/mozilla-1.7.3 -I/usr/include/mozilla-1.7.3/appcomps
-I/usr/include/mozilla-1.7.3/caps -I/usr/include/mozilla-1.7.3/chardet
-I/usr/include/mozilla-1.7.3/content -I/usr/include/mozilla-1.7.3/cookie
-I/usr/include/mozilla-1.7.3/docshell -I/usr/include/mozilla-1.7.3/dom
-I/usr/include/mozilla-1.7.3/exthandler -I/usr/include/mozilla-1.7.3/find
-I/usr/include/mozilla-1.7.3/gfx -I/usr/include/mozilla-1.7.3/helperAppDlg
-I/usr/include/mozilla-1.7.3/history -I/usr/include/mozilla-1.7.3/htmlparser
-I/usr/include/mozilla-1.7.3/java -I/usr/include/mozilla-1.7.3/js
-I/usr/include/mozilla-1.7.3/jsconsole -I/usr/include/mozilla-1.7.3/layout
-I/usr/include/mozilla-1.7.3/locale -I/usr/include/mozilla-1.7.3/mimetype
-I/usr/include/mozilla-1.7.3/mozxfer -I/usr/include/mozilla-1.7.3/necko
-I/usr/include/mozilla-1.7.3/necko2 -I/usr/include/mozilla-1.7.3/nkcache
-I/usr/include/mozilla-1.7.3/oji -I/usr/include/mozilla-1.7.3/pipnss
-I/usr/include/mozilla-1.7.3/pipboot -I/usr/include/mozilla-1.7.3/pref
-I/usr/include/mozilla-1.7.3/progressDlg -I/usr/include/mozilla-1.7.3/sidebar
-I/usr/include/mozilla-1.7.3/shistory -I/usr/include/mozilla-1.7.3/typeaheadfind
-I/usr/include/mozilla-1.7.3/uconv -I/usr/include/mozilla-1.7.3/uriloader
-I/usr/include/mozilla-1.7.3/unicharutil -I/usr/include/mozilla-1.7.3/wallet
-I/usr/include/mozilla-1.7.3/webbrowserpersist
-I/usr/include/mozilla-1.7.3/webbrwsr -I/usr/include/mozilla-1.7.3/webshell
-I/usr/include/mozilla-1.7.3/widget -I/usr/include/mozilla-1.7.3/windowwatcher
-I/usr/include/mozilla-1.7.3/xpconnect -DXTHREADS -D_REENTRANT -DXUSE_MTSAFE_API
-DORBIT2=1 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include
-I/usr/X11R6/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0
-I/usr/include/freetype2 -I/usr/include/freetype2/config -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -I/usr/include/libgnomeui-2.0
-I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0
-I/usr/include/libart-2.0 -I/usr/include/gconf/2 -I/usr/include/libbonoboui-2.0
-I/usr/include/orbit-2.0 -I/usr/include/libbonobo-2.0
-I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include
-I/usr/include/bonobo-activation-2.0 -I/usr/include/libglade-2.0
-I/usr/include/gnome-vfs-module-2.0 -I/usr/include/eel-2 -I/usr/include/gail-1.0
-DLIB_DIR=\"/usr/lib/galeon\" -DSHARE_DIR=\"/usr/share/galeon\"
-DGALEON_MOZILLA_HOME=\"/usr/lib/mozilla-1.7.3\" -D_GNU_SOURCE=1 -include
/usr/include/mozilla-1.7.3/mozilla-config.h -fno-rtti -O2 -g -pipe -m32
-march=i386 -mtune=pentium4 -Wall -Wsign-compare -Wno-ctor-dtor-privacy
-Wno-non-virtual-dtor -Wno-deprecated -fshort-wchar -MT FilePicker.lo -MD -MP
-MF .deps/FilePicker.Tpo -c FilePicker.cpp  -fPIC -DPIC -o .libs/FilePicker.o
FilePicker.cpp:79: error: prototype for `nsresult
GFilePicker::Init(nsIDOMWindowInternal*, const PRUnichar*, PRInt16)' does not
match any in class `GFilePicker'
FilePicker.h:46: error: candidate is: virtual nsresult
GFilePicker::Init(nsIDOMWindow*, const nsAString&, PRInt16)
FilePicker.cpp: In member function `virtual nsresult
GFilePicker::AppendFilters(PRInt32)':
FilePicker.cpp:144: error: no matching function for call to
`GFilePicker::AppendFilter(const PRUnichar*, const PRUnichar*)'
FilePicker.h:46: note: candidates are: virtual nsresult
GFilePicker::AppendFilter(const nsAString&, const nsAString&)
FilePicker.cpp:149: error: no matching function for call to
`GFilePicker::AppendFilter(const PRUnichar*, const PRUnichar*)'
FilePicker.h:46: note: candidates are: virtual nsresult
GFilePicker::AppendFilter(const nsAString&, const nsAString&)
FilePicker.cpp:154: error: no matching function for call to
`GFilePicker::AppendFilter(const PRUnichar*, const PRUnichar*)'
FilePicker.h:46: note: candidates are: virtual nsresult
GFilePicker::AppendFilter(const nsAString&, const nsAString&)
FilePicker.cpp:159: error: no matching function for call to
`GFilePicker::AppendFilter(const PRUnichar*, const PRUnichar*)'
FilePicker.h:46: note: candidates are: virtual nsresult
GFilePicker::AppendFilter(const nsAString&, const nsAString&)
FilePicker.cpp:164: error: no matching function for call to
`GFilePicker::AppendFilter(const PRUnichar*, const PRUnichar*)'
FilePicker.h:46: note: candidates are: virtual nsresult
GFilePicker::AppendFilter(const nsAString&, const nsAString&)
FilePicker.cpp:169: error: no matching function for call to
`GFilePicker::AppendFilter(const PRUnichar*, const PRUnichar*)'
FilePicker.h:46: note: candidates are: virtual nsresult
GFilePicker::AppendFilter(const nsAString&, const nsAString&)
FilePicker.cpp: At global scope:
FilePicker.cpp:183: error: prototype for `nsresult
GFilePicker::AppendFilter(const PRUnichar*, const PRUnichar*)' does not match
any in class `GFilePicker'
FilePicker.h:46: error: candidate is: virtual nsresult
GFilePicker::AppendFilter(const nsAString&, const nsAString&)
FilePicker.cpp:217: error: prototype for `nsresult
GFilePicker::GetDefaultString(PRUnichar**)' does not match any in class
`GFilePicker'
FilePicker.h:46: error: candidate is: virtual nsresult
GFilePicker::GetDefaultString(nsAString&)
FilePicker.cpp:236: error: prototype for `nsresult
GFilePicker::SetDefaultString(const PRUnichar*)' does not match any in class
`GFilePicker'
FilePicker.h:46: error: candidate is: virtual nsresult
GFilePicker::SetDefaultString(const nsAString&)
FilePicker.cpp:265: error: prototype for `nsresult
GFilePicker::GetDefaultExtension(PRUnichar**)' does not match any in class
`GFilePicker'
FilePicker.h:46: error: candidate is: virtual nsresult
GFilePicker::GetDefaultExtension(nsAString&)
FilePicker.cpp:276: error: prototype for `nsresult
GFilePicker::SetDefaultExtension(const PRUnichar*)' does not match any in class
`GFilePicker'
FilePicker.h:46: error: candidate is: virtual nsresult
GFilePicker::SetDefaultExtension(const nsAString&)
make[2]: *** [FilePicker.lo] Error 1
make[2]: Leaving directory `/usr/src/one2team/nim/rpm/BUILD/galeon-1.3.17/mozilla'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/src/one2team/nim/rpm/BUILD/galeon-1.3.17'
make: *** [all] Error 2
erreur: Mauvais status de sortie pour /var/tmp/rpm-tmp.24078 (%build)


Erreur de construction de RPM:
    Mauvais status de sortie pour /var/tmp/rpm-tmp.24078 (%build)
Comment 1 Crispin Flowerday (not receiving bugmail) 2004-10-04 11:57:15 UTC 
Grrr, that isn't really very helpful of the redhat people. 

You should be able to fix it by changing all the
MOZILLA_CHECK_VERSION4(1,8,MOZILLA_ALPHA,1) to MOZILLA_CHECK_VERSION3(1,7,3) in
mozilla/FilePicker.cpp
Comment 2 Nicolas Mailhot 2004-10-04 14:59:14 UTC 
Ok it works with MOZILLA_CHECK_VERSION3(1,7,2) (since we force moz=1.7.2 on
1.7.3  I don't remember exactly why)

Anyway it looks like patched moz 1.7.3 will be the moz version for Fedora Core 3
and maybe even RedHat EL 4 so it might be worth to do something a bit cleaner
for galeon 1.3.18
Comment 3 Crispin Flowerday (not receiving bugmail) 2004-10-09 11:22:00 UTC 
This is fixed in CVS, so 1.3.18 should work much better, we now use explicit
checks for individual API differences rather than version checks:

http://lists.gnome.org/archives/cvs-commits-list/2004-October/msg01899.html