GNOME Bugzilla – Bug 153971
focus line width and padding issues in gnome-applets
Last modified: 2006-10-02 10:13:44 UTC
Please describe the problem: When the panel size is <= 24 pixels, labels in some applets are cropped. This is due to the applet reserving space for the focus line. This bug was first reported against the panel clock applet in bug 147999, however some other applet from gnome-applets are also affected (see screenshot attachment 30409 [details] in bug 147999). I will attach patches for these applets (the dictionary and charpick applets) soon Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 32023 [details] [review] patch for charpick applet This patch makes the charpick applet draw the focus line over the buttons, so the applet looks good even on small panels (no more crop).
Created attachment 32024 [details] [review] patch for the dictionary applet This patch is for the dictionary applet. This applet is actually in gnome-utils, so maybe I should have opened a new bug...
Created attachment 32025 [details] shot showing before and after the patch This shot shows how the applets look is improved by the patch. Ok to commit ? :)
Is this really the fix? Random bits of rc code in the C file doesn't seem right to me. I defer to anyone else on the matter however.
Quick discussion with markmc went something like this: <markmc> Riff, hehe <markmc> yeah <markmc> blame alex <Riff> markmc: is there a better way? <markmc> he did it in libwnck first <markmc> or maybe it was hp <markmc> Riff, not really, we really don't want to care about focus padding on the panel <markmc> Riff, and there's no easier way to override it I guess this means commit it while I look the other way. You'd better make sure Owen and co. are looking the other way too. Add a FIXME or something... it really is quite evil.
I definitely agree that it's weird and looks hackish (and Mark states it explicitely in the original bug)... but I don't see any other way of fixing this in the actual state of things (maybe there's a way to change the focus padding in gtk+ ?) Anyway I'd welcome a more elegant solution anytime ;-)
Agreed, put it in. You'll obviously have to bug the gnome-utils guys for the dictionary applet, but that shouldn't be an issue. I think: /* FIXME * Find a more elegant solution */ should just about cut it as a comment.
Ok, I committed the charpick part. Can I just re-assign the bug to gnome-utils now that the bug is fixed in gnome-applets ?
I have CCed myself for interests sake. Assign away.
Ping : can I apply this patch ?
Committed. Closing the bug.