GNOME Bugzilla – Bug 153517
Sinhala language support in indic-ot module.
Last modified: 2004-12-22 21:47:04 UTC
Indic OT module doesn't have Sinhala language support.
Created attachment 31864 [details] [review] This patch adds Sinhala language support to indic-ot module. We have tested this patch thoroughly. Hope page of Sinhala l10n of GNU/Linux is at http://sinhala.linux.lk . Some screenshots are available at http://www.linux.lk/~anuradha/sinhala/screenshots/0.1-0.2/ .
Created attachment 34315 [details] [review] Fixes a mark
Here's a Sinhala Unicode font that can be utilised to verify the improvement in Sinhala rendering with Pango once the patch is applied: http://www.mrt.ac.lk/sinhala/FM-MalithiUW46.ttf
Excellent looking patch, I've applied it almost verbatim (fixed up a few indentation issues) Tue Dec 14 20:44:53 2004 Owen Taylor <otaylor@redhat.com> Sinhala support (#153517, Anuradha Ratnaweera) * modules/indic/indic-ot.h modules/indic/indic-fc.c modules/indic/indic-ot-class-tables.c: Add tables for Sinhala. * modules/indic/indic-ot.c (indic_ot_reorder): Add handling of Virama for two-part dependent vowels. A comment and a question: - It would be possible to simply reuse fLengthMark instead of adding fVirama. While that would be marginally faster, I've gone with the fVirama addition as cleaner. - You have U+DDE => U+DD9 U+DF3 but the Unicode standard has U+DDE => U+DD9 U+DDF. The forms that Nakanishi shows in his book seem to correspond to what the Unicode standard has. I've left it as you have it, but can you confirm this is correct? Filed against the original ICU sources as http://www.jtcsv.com/cgibin/icu-bugs?findid=4298.
Created attachment 34846 [details] [review] Fixes a split matra Hi Owen, The correct expansion for U+DDE is U+DD9 U+DDF. Attached is the corrected patch. Thanks for attending to the details. As for replacing fVirama, we may need to do a bit more testing, as there are many places things might break. Will submit a new patch soon.
Don't worry about fVirama ... the comment above is a note to myself about why I left it as fVirama rather than something that should be changed. Wed Dec 15 08:38:52 2004 Owen Taylor <otaylor@redhat.com> * modules/indic/indic-ot-class-tables.c: Split U+DDE as U+DD9, U+DDF.