After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 152733 - Cleanup menu.c menu construction code
Cleanup menu.c menu construction code
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-09-15 16:37 UTC by Christian Neumair
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.7/2.8

Attachments
Proposed patch. (9.12 KB, patch)
2004-09-15 16:38 UTC, Christian Neumair 		none Details | Review

Description Christian Neumair 2004-09-15 16:37:06 UTC 
What has been done:
Remove "fake_submenu" parameter. It controls whether submenus should simply be
created (i.e. filled on popup), or filled at construction time. All calls pass
FALSE. If I remember correctly, it was only TRUE for the applet context menu.
Remove "force" parameter. I don't know why one should pass TRUE anyway. Maybe
legacy cruft.

regs,
 Chris
Comment 1 Christian Neumair 2004-09-15 16:38:16 UTC 
Created attachment 31583 [details] [review]
Proposed patch.

Patch doing what I described above.
Comment 2 Christian Neumair 2004-10-17 09:43:17 UTC 
Any news?
Comment 3 Mark McLoughlin 2004-11-11 09:25:51 UTC 
Thanks for the patch Manny - you were right on both counts and I did both when
re-writing the menu code to use libgnome-menu