After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 150611 - Images are not rotated according to EXIF data on display
Images are not rotated according to EXIF data on display
Status: RESOLVED WONTFIX
Product: gthumb
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2004-08-20 05:25 UTC by Rennie deGraaf
Modified: 2005-11-01 01:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
EXIF orientation patch (19.12 KB, patch)
2004-08-20 05:30 UTC, Rennie deGraaf
none Details | Review
patch to rotate according to EXIF information, against CVS tree 20041216 (20.93 KB, patch)
2004-12-30 21:16 UTC, Rennie deGraaf
none Details | Review
Patch against gthumb 2.6.8 (22.11 KB, patch)
2005-11-01 01:07 UTC, Rennie deGraaf
none Details | Review

Description Rennie deGraaf 2004-08-20 05:25:15 UTC
When a jpeg image is displayed using gthumb 2.5.0, the EXIF orientation field is
not taken into consideration when orienting the image.  If the value if the
orientation field is not "top left", then the image will not be oriented correctly.

Patch to follow.
Comment 1 Rennie deGraaf 2004-08-20 05:30:22 UTC
Created attachment 30775 [details] [review]
EXIF orientation patch

This patch adds support for the EXIF orientation field to the image loader. 
When an image is loaded with this field present, the image is rotated according
to the field's value.

This was accomplished by moving gth-exif-utils.h and gth-exif-utils.c from the
main gthumb module into libgthumb, and copying some code from
src/dlg-jpegtrans.c into libgthumb/image-loader.c.
Comment 2 Paolo Bacchilega 2004-12-20 15:19:53 UTC
I won't apply this path because images must be viewed as they are not as they
should be, if the user wants to rotate the image he can use the rotate tool.
Comment 3 Ryan McDougall 2004-12-29 14:36:50 UTC
Why on earth should should you ignore EXIF orientation so long as its correct?
Why should you force the user to manually fix all their pictures, when the EXIF
data is there precisely to avoid that sort of meaningless labour?

If the user decides to change the orientation later, can't the EXIF field be
overwritten with the new orientation?

Your comment isn't sufficient to justify why you are right. Can you elaborate
why you wont fix it?
Comment 4 Rennie deGraaf 2004-12-30 21:16:09 UTC
Created attachment 35309 [details] [review]
patch to rotate according to EXIF information, against CVS tree 20041216
Comment 5 Rennie deGraaf 2005-11-01 01:07:45 UTC
Created attachment 54169 [details] [review]
Patch against gthumb 2.6.8