After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 148528 - on win32 gdk_drag_find_window_for_screen doesn't work with certain desktop layouts
on win32 gdk_drag_find_window_for_screen doesn't work with certain desktop la...
Status: RESOLVED DUPLICATE of bug 141842
Product: gtk+
Classification: Platform
Component: Backend: Win32
2.4.x
Other Windows
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2004-07-26 23:54 UTC by Tim Evans
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch against gtk+-2.4.1 (1.25 KB, patch)
2004-07-27 00:04 UTC, Tim Evans
none Details | Review
improved patch that fixes just the bug in gdkdnd-win32.c (1.56 KB, patch)
2004-07-27 22:24 UTC, Tim Evans
none Details | Review

Description Tim Evans 2004-07-26 23:54:55 UTC
There are two possible ways to reproduce this bug:

1. Place your start bar at the top (or left) of the screen.

2. Have multiple monitors where the primary monitor is not at the top left of
the virtual desktop.

The drag and drop fails because in two different places GTK and GDK are
comparing coordinates in one coordinate system with coordinates in another.  One
half of that gdk_window_get_origin seems returns values reltive to the primary
dsektop and all other coordinates seem to be relative to the virtual desktop
(bug #148526).  The other half is in gdkdnd-win32.c where it does something
similar iternally when searching for the dnd target window.
Comment 1 Tim Evans 2004-07-27 00:04:11 UTC
Created attachment 29913 [details] [review]
Patch against gtk+-2.4.1

This patch fixes a bug in gdk/win32/gdkdnd-win32.c and works around bug #148526
by modifying gtk/gtkdnd.c
Comment 2 Owen Taylor 2004-07-27 16:53:47 UTC
Modifying one part of GTK+ to work around a bug in another part is never
right. The change in gdkdnd-win32.c doesn't look right either - all
coordinates should be absolute there, not screen relative.

*** This bug has been marked as a duplicate of 148526 ***
Comment 3 Tim Evans 2004-07-27 22:24:09 UTC
Created attachment 29972 [details] [review]
improved patch that fixes just the bug in gdkdnd-win32.c
Comment 4 Tim Evans 2004-07-27 22:26:48 UTC
This new patch fixes just the bug in gdkdnd-win32.c, which is different than bug
#148526.  The new patch leaves coordinates in absolute coordinates (i.e.
relative to the entire virtual desktop) as much as possible, with the
restriction that ScreenToClient does not operate in that coordinate space.
Comment 5 Robert Ögren 2004-07-27 23:25:10 UTC
Have you checked that this isn't the same as bug #141842?
Comment 6 Tim Evans 2004-07-27 23:41:52 UTC
Yes, it is the same.  Sorry.

*** This bug has been marked as a duplicate of 141842 ***