After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 147572 - Wrong menu item of "Move to another workspace" submenu de-sensitzed.
Wrong menu item of "Move to another workspace" submenu de-sensitzed.
Status: RESOLVED FIXED
Product: libwnck
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libwnck maintainers
libwnck maintainers
Depends on:
Blocks:
 
 
Reported: 2004-07-14 12:35 UTC by Arvind S N
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch fixes the bug (2.27 KB, patch)
2004-07-14 12:36 UTC, Arvind S N 		needs-work Details | Review
Reworked patch based on Havoc's comments (1.97 KB, patch)
2004-07-15 04:48 UTC, Arvind S N 		accepted-commit_now Details | Review

Description Arvind S N 2004-07-14 12:35:33 UTC 
1) Be on workspace 3.
2) Right click on a task in window list and put it on all workspaces.
3) Right click again on the task, ->Move to another workspace
4) Notice the submenu, the first workspace is de-sensitzed

The third workspace should have been de-sensitzed instead of the first.

Will attach a patch in a minute
Comment 1 Arvind S N 2004-07-14 12:36:54 UTC 
Created attachment 29529 [details] [review]
patch fixes the bug
Comment 2 Havoc Pennington 2004-07-15 00:43:49 UTC 
Comment on attachment 29529 [details] [review]
patch fixes the bug

I would say that if the window is on all spaces, no menu item should be
insensitive (this matches metacity's behavior). Moving an on-all-spaces window
to any space makes it no longer on-all-spaces.

The simple way is if (workspace == NULL) present_workspace = -1 and then
present_workspace will never be equal to "i" in the loop.
Comment 3 Arvind S N 2004-07-15 04:48:47 UTC 
Created attachment 29541 [details] [review]
Reworked patch based on Havoc's comments
Comment 4 Havoc Pennington 2004-07-18 00:29:02 UTC 
Comment on attachment 29541 [details] [review]
Reworked patch based on Havoc's comments

Looks great, thanks.
Comment 5 Arvind S N 2004-07-20 04:52:22 UTC 
Committed to HEAD. Thanks Havoc :)