After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 144240 - [cdparanoia] sets wrong timestamps on buffers [patch]
[cdparanoia] sets wrong timestamps on buffers [patch]
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal normal
: 0.8.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-06-13 00:30 UTC by Tim-Philipp Müller
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (3.80 KB, patch)
2004-06-13 00:33 UTC, Tim-Philipp Müller
none Details | Review
proposed patch (sane version) (2.73 KB, patch)
2004-06-13 12:39 UTC, Tim-Philipp Müller
none Details | Review
proposed patch (2.69 KB, patch)
2004-06-13 14:35 UTC, Tim-Philipp Müller
none Details | Review

Description Tim-Philipp Müller 2004-06-13 00:30:17 UTC
cdparanoia sets consecutive timestamps on buffers (just for the sake of having 
a timestamp, it seems), which are just steadily increased and not affected by 
seeking, changing of tracks etc. 
 
This means that a query on the audiosink (or cdparanoia) will produce a time 
stamp that has no relation to the position currently being played back, which 
seems very undesirable for audio players etc. 
 
Instead, cdparanoia should set timestamps on buffers that represent the 
current position within the CD, ie. since the start of the CD, and send 
discont events on seeking/track changing IMHO. 
 
Patch attached. 
 
I realise the hack with g_object_{get|set}_qdata() is ugly, but it's the only 
sane way I could come up with to compensate for the missing padding. 
 
Tested with alsasink and artsdsink. 
 
Cheers 
 -Tim
Comment 1 Tim-Philipp Müller 2004-06-13 00:33:56 UTC
Created attachment 28647 [details] [review]
proposed patch
Comment 2 Tim-Philipp Müller 2004-06-13 12:39:47 UTC
Created attachment 28656 [details] [review]
proposed patch (sane version)

Erm, please ignore the first patch and pretend you've never seen it.

New patch attached, without all the unnecessary _{get|set}_qdata() stuff.

Cheers
 -Tim
Comment 3 Ronald Bultje 2004-06-13 14:25:01 UTC
There's still a comment about padding in there - it's unneeded. Padding only
applies to public exported ABI/API. :).
Comment 4 Tim-Philipp Müller 2004-06-13 14:35:24 UTC
Created attachment 28658 [details] [review]
proposed patch

For some reason I thought plugin headers were semi-public as well, sorry. 

New patch without those comments attached.

Cheers
 -Tim
Comment 5 David Schleef 2004-06-14 20:34:44 UTC
Applied, thanks.