GNOME Bugzilla – Bug 141736
Configure broken in NetBSD
Last modified: 2004-12-22 21:47:04 UTC
The changes done to fix bug #136468 broke the configure script in NetBSD, where gnome-vfs is now unbuildable. The problem is that the <sys/mount.h> header is included "directly" in the checks, but <sys/param.h> is *required* as a prerequisite in NetBSD. Therefore, it must be included by hand before sys/mount.h to get those checks working.
Created attachment 27337 [details] [review] Sample patch
Created attachment 27370 [details] [review] New patch The previous patch fixed configure in NetBSD up to 2.0, but not current. In current, statvfs exists, but statfs does not. So the configure script fails because it says there is no statfs (but it should work, because statvfs was previously detected). This new patch fixes both issues.
http://cvs.gnome.org/viewcvs/gnome-vfs/configure.in?r1=1.295.2.7&r2=1.295.2.8 has been committed, as far as I can tell it fixes the sys/param.h issue Is something else needed, or is this patch enough ?
This commit does exactly the same as my first patch in this PR. Thanks for fixing. However, the second patch (named "New patch"), includes an extra chunk that hasn't been applied. As said, in NetBSD current (post 2.0D), the system has statvfs but not statfs. The problem is that the script stops configuration if statfs is not found, _even if statvfs exists_. It should only stop if both functions are missing, which is what the patch does.
Is the missing chunk this one: @@ -262,7 +274,9 @@ statfs(NULL, &st, sizeof (st), 0);],[ AC_MSG_RESULT([4]) AC_DEFINE(STATFS_ARGS, 4, [Number of arguments to statfs()])],[ AC_MSG_RESULT(unknown) - AC_MSG_ERROR([unable to determine number of arguments to statfs()])])]) + if test "x`echo $ac_cv_func_statvfs | $as_tr_sh`" = "xno"; then + AC_MSG_ERROR([unable to determine number of arguments to statfs()])]) + fi]) ? Doesn't that belong to bug #141739 instead?
Yes and yes. Well, as this bug was originally filled to solve configuration problems, I attached this last chunk to it so that configure works fine. But it may suit better the other bug, #141739.
Ok, so I'll move this chunk to bug #141739 so that I can close this bug ;)