After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 141652 - Epiphany re-downloads file on File -> Save
Epiphany re-downloads file on File -> Save
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Downloads
1.2.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
needs-forwarding
: 168554 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-05-02 16:23 UTC by Crispin Flowerday (not receiving bugmail)
Modified: 2007-07-31 04:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
(partial?) fix (1.73 KB, patch)
2004-05-03 14:17 UTC, Christian Persch
committed Details | Review
updated patch (5.13 KB, patch)
2004-05-03 14:40 UTC, Christian Persch
none Details | Review

Description Crispin Flowerday (not receiving bugmail) 2004-05-02 16:23:07 UTC
If you are viewing a bugzilla bug list (as an example), epiphany re-downloads
the file when you do File -> Save. This is especially annoying for cgi scripts
that change output when they are viewed.

(epiphany 1.2.3)
Comment 1 Christian Persch 2004-05-02 17:26:14 UTC
Also reproducible with HEAD.
Comment 2 Christian Persch 2004-05-03 14:17:58 UTC
Created attachment 27333 [details] [review]
(partial?) fix

With the above patch, when I
- load a page,
- modify it on the server,
- save it from the browser,
I get the original, not the modified content. However, tcpdump reveals there
still is http traffic ongoing...

Marco, any ideas?
Comment 3 Christian Persch 2004-05-03 14:40:30 UTC
Created attachment 27338 [details] [review]
updated patch
Comment 4 Marco Pesenti Gritti 2004-05-03 17:15:39 UTC
Comment on attachment 27333 [details] [review]
(partial?) fix

Maybe add a comment on the ENSURE_TRUE and remove the double \n
Comment 5 Christian Persch 2004-05-03 19:08:16 UTC
Comment on attachment 27333 [details] [review]
(partial?) fix

Committed to HEAD and gnome-2-6.

Should we still file a mozilla bug about using cache keys for the content
files?
Comment 6 Marco Pesenti Gritti 2004-05-23 02:03:00 UTC
Yeah, let's file a bug for it.
Comment 7 Marco Pesenti Gritti 2004-06-07 22:57:16 UTC
Normal, we just need to file a bug.
Comment 8 Christian Persch 2004-10-13 10:55:29 UTC
Mass reassigning of Epiphany bugs to epiphany-maint@b.g.o
Comment 9 Bastien Nocera 2006-01-12 16:28:18 UTC
Same tests as for bug #308403
For POST:
http://hadess.free.fr/test308403-post.php
For GET:
http://hadess.free.fr/test308403.php
Comment 10 Reinout van Schouwen 2007-02-14 17:10:49 UTC
Bastien, what are these tests supposed to show? Is this bug still valid?
Comment 11 Bastien Nocera 2007-02-14 17:38:41 UTC
(In reply to comment #10)
> Bastien, what are these tests supposed to show? Is this bug still valid?

http://hadess.free.fr/test308403.php is gone.

1. Go to http://hadess.free.fr/test308403-post.php
2. Click on "submit query"
3. See "My test is rich"
4. Save the file using "file->save"
If it works properly, you should see:
"My test is rich"
If it doesn't work properly, you should see:
"No value"
in the saved file.

Don't know if it's still valid, it seems to work fine with ephy 2.16.3 on FC6.
Comment 12 Diego Escalante Urrelo (not reading bugmail) 2007-04-25 00:17:58 UTC
Isn't #168554 a duplicate of this one?.
Comment 13 Christian Persch 2007-04-25 08:43:15 UTC
*** Bug 168554 has been marked as a duplicate of this bug. ***
Comment 14 trollord 2007-07-17 20:41:08 UTC
2.18.1 on Ubuntu Feisty, does not seem to re-download the content anymore when saving. 
Comment 15 Diego Escalante Urrelo (not reading bugmail) 2007-07-31 04:21:15 UTC
Works here too. Closing.