GNOME Bugzilla – Bug 141386
Make it easier to change patch statuses
Last modified: 2005-03-15 10:40:09 UTC
it would be very useful to change the patch status using a dropdown list in show_bug.cgi rather than have to go off into attachment.cgi?action=view. Just something like: - accepted, commit now - accepted, commit later - needs work - committed Maybe an "obsolete" checkbox would be good too.
I'm not sure on this one. I'd be thinking that maybe making clicking on the patch open in the editor by default and having a "Download" link would be more useful; in bugzilla, looking at patches for sanity is probably the common case and then you want to be able to edit/add comments/change statuses etc.
Unless its a tiny patch, I always do something along the lines of: 1) Download patch 2) Either apply, clean up, commit or read it in one emacs buffer while reading the actual code in another buffer 3) Either reply in detail (lots of text usually - the little input box on the patch review page wouldn't be big enough) and mark as needs-work, commit a cleaned up patch myself and mark resolved or mark as commit-now. I guess what I'm saying is the patch editor thing just doesn't work for large patches and I'd prefer not to have to use it at all for those patches.
Oops.. sorry, didn't mean to change this bug.
I have to really agree with Mark; patch review currently is a big pain and I think his suggestion would make things much nicer, for me at least. I think we should still leave the current way of patch review because there are some circumstances where it's easier to use (and some people may prefer always using that way--it may be a difference in workflows).
Okay, although it's probably superfluous, just for sake of completeness of this bug in bugzilla here's the reasons I think the current patch review method sucks: 1) Can only mark one patch at a time 2) Must open a separate page for each patch to be reviewed a) New page doesn't show the same details as the main page (i.e. previous comments) b) This is often slow if either window is under heavy load (happens periodically throughout the day) or the user's internet connection isn't the greatest 3) The box for comments when marking a patches status is *ridiculously* small 4) It's confusing--it allows things like having the patch simultaneously have the states "accepted-commit_now" and "rejected" Anyway, I'll attach a patch in just a minute that I just barely committed (tested heavily on my local bugzilla-new installation).
Created attachment 38727 [details] [review] Give drop-down box for setting patch statuses Okay, points to note, as I talked about with Luis in IRC: 1) Handling of multiple states--My dropdown box basically handles if a patch already has multiple statuses set (and tries to pick the most sane one to display), but if you use it to change things, it removes all statuses except the one you select 2) My patch doesn't check for switching of products because all of our states are currently global; we may want to consider doing something more if we ever change that 3) attachstatuses and attachstatusdefs are nuked in bugzilla > 2.17. So, this stuff will need to be updated. (The patch is mainly just additions as opposed to modifications, so this shouldn't be bad, and in the worst case can just be removed fairly easily.) I'll volunteer to help with this (as well as the reports and maybe other stuff) in the upcoming bugzilla upgrade if Olav wants/needs the help.
Elijah, you legend ! :-)