After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 140836 - text field (for numerals) hard to delineate in a11y themes
text field (for numerals) hard to delineate in a11y themes
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
AP3
Depends on:
Blocks:
 
 
Reported: 2004-04-22 12:59 UTC by Patrick Wade
Modified: 2009-06-24 04:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
calc using High Contrast Inverse theme - text field hard to locate (30.62 KB, image/png)
2004-04-22 13:01 UTC, Patrick Wade
Details
calc using High Contrast theme - text field hard to locate (28.12 KB, image/png)
2004-04-22 13:01 UTC, Patrick Wade
Details
The bug is fixed (16.02 KB, image/png)
2005-12-20 10:50 UTC, Stephane Raimbault
Details

Description Patrick Wade 2004-04-22 12:59:05 UTC
Running GNOME built using gcalctool-4.3.50-9 source tarball:


-Change the theme to High Contrast Large Print Inverse
-Open the gnome calculator

Observe that the the area limits of the text field
(for the numerals) cannot really be seen, and this makes
direct entry of numerals into the field difficult for
vision-impaired users.
Comment 1 Patrick Wade 2004-04-22 13:01:10 UTC
Created attachment 26963 [details]
calc using High Contrast Inverse theme - text field hard to locate
Comment 2 Patrick Wade 2004-04-22 13:01:53 UTC
Created attachment 26964 [details]
calc using High Contrast theme - text field hard to locate
Comment 3 bill.haneman 2004-04-23 12:31:29 UTC
This is a regression in gcalctool, since version 4.3.38 does not have this
problem, but 4.3.50 does.  Rich, it looks as though you either removed a frame
or changed its widget type... can you have a look?  thanks.
Comment 4 Rich Burridge 2004-05-17 19:48:50 UTC
I've just tried this with gcalctool v4.3.51 and GNOME 2.6 (cinnibar-lite
on Solaris x86). I did not see a "High Contrast Large Print Inverse" 
theme there, but I tried it with "High Contrast Inverse" and "Large Print" 
and had no problems seeing the display text field.

Comment 5 bill.haneman 2004-05-17 19:54:10 UTC
Rich: did the display text field have a contrasting border around it?  In our
tests (calum and myself), there was a contrasting border in 4.3.38 but not in
4.3.50.  If your gcalctool looks like that in Patrick's attachments (ignoring
the text itself, but concentrating on the delineation of the text field's
borders), then we have a problem.
Comment 6 Rich Burridge 2004-05-17 20:20:52 UTC
Ah, I think I understand what you are talking about now.
Then it looks like the change to "fix":

http://bugzilla.gnome.org/show_bug.cgi?id=132570

is the culprit here. Add Calum to the CC: list here as
this appears to be a HIGy thing.
Comment 7 Calum Benson 2004-10-21 16:47:03 UTC
Apologies for spam-- ensuring Sun a11y team are cc'ed on all current a11y bugs.
 Filter on "SUN A11Y SPAM" to ignore.
Comment 8 Rich Burridge 2005-09-13 21:44:09 UTC
Hi. I'm trying to fix/close gcalctool bugs. Bill, Calum how would you
like this one fixed?
Comment 9 Stephane Raimbault 2005-12-20 10:45:16 UTC
In gcalctool 5.6.31, it doesn't seem possible to have a void text (numeral) entry so it's more easy to locate the field.
Comment 10 Stephane Raimbault 2005-12-20 10:50:07 UTC
Created attachment 56196 [details]
The bug is fixed

gcalctool 5.6.31 on Ubuntu Breezy 5.10 and a11y theme.
Comment 11 bill.haneman 2005-12-20 11:41:53 UTC
The behavioral change mentioned in comment #9 has reduced the problem.  The underlying issue with frameless layout is still there however.
Comment 12 Calum Benson 2006-04-26 17:07:50 UTC
Apologies for spam... ensuring Sun a11y folks are cc'ed on all current accessibility bugs.
Comment 13 André Klapper 2006-09-30 09:08:54 UTC
reopening as this is still there according to bill in comment 11.
Comment 14 Rich Burridge 2007-03-12 16:51:01 UTC
What do we want to change in gcalctool to fix this?
Calum can use suggest a change please? We either fix
this or close it as WONTFIX. It's been open for almost
three years now. Thanks.
Comment 15 Calum Benson 2007-03-15 18:23:54 UTC
Hmm, well, I've just noticed something interesting.

If I use the sample ~/.gcalctoolrc file (from the svn module), I get a nice solid border around the numeric display area with the high contrast inverse themes (but still not the regular high contrast themes).  If I remove the ~/.gcalctoolrc file, I get no border.

So maybe one possible fix here is to work out what in the .rc file is making the border appear with the inverse themes, and make it happen for all the a11y themes all the time...?

(Aside to Rich: has also just become apparent that the reason my .gcalctoolrc file was apparently doing nothing up to now is down to Sun's Nimbus and Blueprint themes/engines-- they pretty much over-ride the .rc file completely.  With other themes/engines, the buttons do take on at least *some* colour.  You might want to file Nimbus/Blueprint bugs about that, although I doubt it'll be a high priority fix...)
Comment 16 Rich Burridge 2007-03-15 18:44:44 UTC
I see the solid border in the two high contrast inverse themes,
like you said, but not in the "High Contrast, Large Print" theme.
Shouldn't it be there too? The way the radio buttons are rendered
suggest that it should.

I'll investigate what's going on here, but I'll need a pointer
first please? Where are the themes stored? 

Thanks!
Comment 17 Calum Benson 2007-03-20 10:54:16 UTC
Yes, I expect we'd want a border in all variants of the high contrast themes.

First thing to check would probably be /usr/share/themes/<themename>/gtk-2.0/gtkrc-- it's possible there's an unintentional difference between the gtkrc files for the themes where the border appears, and the ones where it doesn't.

On the other hand, it's possible there's a glitch in the HC gtk theme engine (/usr/lib/gtk-2.0/<gtk-version>/engines/libhcengine.so), in which case somebody more knowledgable than me will have to assist :/  (The source code for that is in the gtk-engines module.)
Comment 18 Rich Burridge 2007-11-03 15:20:35 UTC
Now that we've got a "gcalctool-maint@gnome.bugs" alias, I'm
reassigning several bugs and enhancement back to that. They
are free to be picked up by one of the team and worked on.

Now that gcalctool has been Glade'd, I'm hoping that this 
problem will be easier to find and fix.
Comment 19 Robert Ancell 2009-06-24 04:00:22 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

http://git.gnome.org/cgit/gcalctool/commit/?id=0bc717a6a62350fa775e0cf2a432e64dd335cc4c