After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 140536 - Critical path broken
Critical path broken
Status: RESOLVED FIXED
Product: planner
Classification: Other
Component: General
unspecified
Other Linux
: Normal normal
: 0.13
Assigned To: planner-maint
planner-maint
Depends on:
Blocks:
 
 
Reported: 2004-04-19 19:16 UTC by Richard Hult
Modified: 2005-02-12 11:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Test case (1.91 KB, patch)
2004-04-19 19:17 UTC, Richard Hult
none Details | Review

Description Richard Hult 2004-04-19 19:16:37 UTC
The attached file doesn't show the correct critial path
Comment 1 Richard Hult 2004-04-19 19:17:20 UTC
Created attachment 26831 [details] [review]
Test case
Comment 2 Mikael Hallendal 2004-04-20 08:49:04 UTC
Is this something that broke during 0.11 -> 0.12 phase?
Comment 3 Richard Hult 2004-04-20 08:54:13 UTC
Don't think so (if someone wants to fix it for 0.12 that would be nice though).
Comment 4 Doroszlai Attila 2004-04-20 11:28:42 UTC
It definitely didn't break during the 0.11->0.12.  I tried it with 0.11 and
highlight for the test case is the same (actually, I reproduced the test case
because it wouldn't load in 0.11).

I'll see to this one.
Comment 5 Mikael Hallendal 2004-04-20 11:59:21 UTC
OK, great, then it's fine to keep this on 0.13, if you have the time to fix it
before 0.12 it'll be all the better.

Cheers!
Comment 6 Xavier Ordoquy 2004-07-27 08:41:07 UTC
The trouble here is that the B task latest end is computed as the minimum value
between the project end and the latest end with successor. But B has no successor.
The latest end computation should also take into account the subtasks latest end
when computing the latest end.
Comment 7 Richard Hult 2004-07-27 08:42:51 UTC
Yay, good catch, great! :)
Comment 8 Richard Hult 2004-10-06 20:11:14 UTC
The description above is a bit wrong, it should be:

Latest finish of B is minimum of project finish and latest START of any successor.

I suspect that the problem really is that the dependency list (the order in
which to go through tasks) is calculated for the forward pass, which puts
children before parents. When we then reverse the list for the backwards pass,
parents are handled before children. I think we should go through children
before parents and do like in the forward pass, i.e. to get the min/max values
from the children for summary tasks.
Comment 9 Richard Hult 2005-02-12 11:38:13 UTC
Should be fixed in CVS.