After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 139393 - Make GnomeVFSGetFileInfoResult and GnomeVFSFindDirectoryResult be real boxed types.
Make GnomeVFSGetFileInfoResult and GnomeVFSFindDirectoryResult be real boxed ...
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: Async operations
cvs (head)
Other All
: Normal normal
: ---
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
Depends on:
Blocks:
 
 
Reported: 2004-04-07 16:27 UTC by Murray Cumming
Modified: 2005-05-06 11:55 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
gnome-vfs-boxedtypes.patch (6.17 KB, patch)
2004-04-07 16:29 UTC, Murray Cumming 		needs-work Details | Review
gnome-vfs-boxedtypes2.patch (5.82 KB, patch)
2005-05-03 10:27 UTC, Murray Cumming 		none Details | Review
gnome-vfs-boxedtypes3.patch (5.82 KB, patch)
2005-05-03 10:30 UTC, Murray Cumming 		committed Details | Review

Description Murray Cumming 2004-04-07 16:27:51 UTC 
This patch adds get_type, copy, and free functions for GnomeVFSGetFileInfoResult
and GnomeVFSFindDirectoryResult, so that they are real gtype boxed types. This
makes life easier for language bindings.


I have also changed the struct declarations to use the GTK+ technique:
  typedef _Something Something;
  struct _Something {};

This alllows gnome-vfsmm to use prototype declarations instead of including the
gnome-vfs headers in our public headers, like so:

typedef struct _Something Something;

If you don't mind that here then I'll patch the rest of gnome-vfs to do it too.
Comment 1 Murray Cumming 2004-04-07 16:29:37 UTC 
Created attachment 26439 [details] [review]
gnome-vfs-boxedtypes.patch
Comment 2 Alexander Larsson 2004-04-16 09:33:07 UTC 
The concept looks fine to me, for HEAD (can't add api like that in 2.6). However
the patch looks like it has some FIXME comments and is not in gnome-vfs style
indentation. The gnome-vfs indentation isn't perfectly consistent atm, but its
mostly nautilus-style, and i try to move it towards that. (See
nautilus/docs/style-guide.html)
Comment 3 Christian Neumair 2005-05-02 11:59:21 UTC 
Murray: Any chance that you resend this patch with the suggested fixes? :)
Comment 4 Murray Cumming 2005-05-03 10:27:43 UTC 
Created attachment 45975 [details] [review]
gnome-vfs-boxedtypes2.patch

Revised patch. Sorry, the comments were from my C++ code, telling me to submit
this patch.
Comment 5 Murray Cumming 2005-05-03 10:30:56 UTC 
Created attachment 45976 [details] [review]
gnome-vfs-boxedtypes3.patch

This one even builds.
Comment 6 Christian Kellner 2005-05-06 11:55:36 UTC 
Commited a slightly diffrent version to cvs HEAD. Thanks Murray and Manny!