GNOME Bugzilla – Bug 138714
Py-Slice should use file chooser for "Path to export HTML to"
Last modified: 2006-07-20 08:19:07 UTC
Py-slice...the motive why a web developer doesn need gimp-perl and could go with gimp-python instead. Can not,as of gimp 2.0.0: - Work if there are only horizontal or only vertical guides, but just with both. This is just becasue of a misplaced "and" in the beggining of the plug-in - Correctly save images to a different directory of the one of the base HTML file: Images relative paths doesn't apear in src attributes of img tags in generated html/ - (enhancement) - "Path to export HTML to" should be a PF-FILE entry, not a PF-String. I've Addressed this, taking care to pick the directory only part of choosen path. I will atach a patch addressing all 3 bugs. I think they can go straight into 2.0.1
Created attachment 26189 [details] [review] Patch fixing all three bugs
I'll commit a somewhat tweaked version of this after some testing.
*** Bug 138827 has been marked as a duplicate of this bug. ***
Yosh, will you commit your changes or would you like to wait till 2.0.1 is out?
I'd like to get it in for 2.0.1, but I won't get a chance till 4-5 hours from now.
I will wait as long as it takes then.
2004-04-11 Manish Singh <yosh@gimp.org> * plug-ins/pygimp/plug-ins/py-slice.py: When using a separate dir for images, actually prepend the dir to the img srcs in the html. Allow only horizontal or vertical guides in an image, do not require both. A bit smarter path handling. Addresses most of bug #138714.
I didn't do the PF_FILE change because pygimp's filesel stuff is a little wonky right now. Will address after 2.0.1.
Yosh, did you get around to look at this in the meantime?
I think this should be part of the larger pygimp changes that will go in 2.2.
Will the larger pygimp changes be ready in time for 2.2?
Yosh, I've browsed through the code, and now I can imagine what are these "larger pygimp changes". Widget diversification and layout, and internationalization come to mind. I am willing to help. That means, I can implement something as of now - I just would like to know what you have thought about these issues. Maybe we should open a tracker bug for pygimp and work there? Sven - looking at the code, I'd say it can be done in time for 2.2, but not in time for the proposed string-freeze. Once i18n is not in place in pygimp as of now, even if Pygimp is not coming into a separate tree, I think this should no t block the string freeze. Anyway, it should go into a separate translation module.
The best thing to do here is to move pygimp into a separate module. It can be released independently then and we don't need to wait for pygimp with the 2.2 release.
Yosh, are you still planning to do any major changes to pygimp before 2.2? Otherwise I'd suggest to just ship 2.2 with the current state of pygimp and move this bug report to the Future milestone.
Bumping it. No time for pre-2.2 for this.
Does the version attached to bug 159564 address this as well?
I incorrectly listed 3 issues when reporting this bug. Two of then are corrected, and the only thing remaining is that the "Path to export HTML to" is a string when it would be correct if it were a file widget. Yosh preferred to let it this way because the PF_FILE widget is not a nice file selector (see comment #8), and I am using it just how it was left over. However, I consider that displaying a string widget when the input should be a filesystem object is a bug - it just depends on another bug: fixing the Python-fu file selector widget, as in #8.
Could you please update the summary to something useful then? :) Maybe it could be a good idea to close this bug and open a new one for just the PF_FILE issue (with a dependency on the PF_FILE enhancement request) pyslice has, this one is rather confusing and mostly obsolete already.
This is an enhancement request now that the bug parts are fixed, and I've updated the summary to something useful :)
2006-07-20 Manish Singh <yosh@gimp.org> * plug-ins/pygimp/plug-ins/py-slice.py: use PF_DIRNAME for save_path. Fixes bug #138714.