After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 138512 - intltool: "make check" fails
intltool: "make check" fails
Status: RESOLVED FIXED
Product: intltool
Classification: Deprecated
Component: general
unspecified
Other All
: High normal
: ---
Assigned To: intltool maintainers
intltool maintainers
Depends on: 46650 130802
Blocks:
 
 
Reported: 2004-03-30 13:56 UTC by Adrian Bunk
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.5/2.6


Attachments
Fix test 8: merging translations into Dia-style XML file (2.26 KB, patch)
2004-06-14 09:31 UTC, Danilo Segan
committed Details | Review

Description Adrian Bunk 2004-03-30 13:56:54 UTC
I got the following output of "make check":

<--  snip  -->

 1. Extract messages from simple desktop file:                       [OK]
 2. Merge translations into a Bonobo UI style file:                  [OK]
 3. Extract messages from a multi-line XML file:                     [OK]
 4. Merge translations into a multi-line XML file:                   [OK]
 5. Extract messages with unusual characters in the XML tag:         [OK]
 6. Merge translations into a pong style XML file:                   [OK]
 7. Extract messages from a glade style XML file:                    [OK]
 8. Merge translations into a dia sheet style XML file:              [OK]
 9. Merge translations into a dia sheet style XML file [broken XML]: [OK]
10. Merge translations that include escaped .po strings:             [FAILED]
(merge6.xml)
11. Merge translations into a .keys file:                            [OK]
12. Extract messages from a glade 2.0 style XML file:                [OK]
13. Extract messages from an rfc822 style file:                      [OK]
14. Merge translations into an rfc822 style file:                    [OK]
15. Extract messages from a gconf schema style file:                 [OK]
16. Merge translations into a gconf schema  style file:              [OK]
17. Extract messages from a xml file using the xml:space attribute:  [OK]
18. Merge translations into multiple files:  [FAILED] (merge6.xml)
FAIL: selftest
===================
1 of 1 tests failed
===================

<--  snip  -->
Comment 1 terry l. ridder 2004-04-01 06:51:31 UTC
intlttool-0.30 downloaded from gnome-2.6 source directory on 31 mar 2004.

Running self test of the intltool module

 1. Extract messages from simple desktop file:                       [OK]
 2. Merge translations into a Bonobo UI style file:                  [OK]
 3. Extract messages from a multi-line XML file:                     [OK]
 4. Merge translations into a multi-line XML file:                   [OK]
 5. Extract messages with unusual characters in the XML tag:         [OK]
 6. Merge translations into a pong style XML file:                   [OK]
 7. Extract messages from a glade style XML file:                    [OK]
 8. Merge translations into a dia sheet style XML file:              [FAILED]
(merge5u.sheet)
 9. Merge translations into a dia sheet style XML file [broken XML]: [OK]
10. Merge translations that include escaped .po strings:             [FAILED]
(merge6.xml)
11. Merge translations into a .keys file:                            [OK]
12. Extract messages from a glade 2.0 style XML file:                [OK]
13. Extract messages from an rfc822 style file:                      [OK]
14. Merge translations into an rfc822 style file:                    [OK]
15. Extract messages from a gconf schema style file:                 [OK]
16. Merge translations into a gconf schema  style file:              [OK]
17. Extract messages from a xml file using the xml:space attribute:  [OK]
18. Merge translations into multiple files:  [FAILED] (merge6.xml)
FAIL: selftest
===================
1 of 1 tests failed
===================
Comment 2 Kenneth Rohde Christiansen 2004-04-26 08:58:47 UTC
This is awaiting some changed that need to be committed soon.
Comment 3 Danilo Segan 2004-06-14 09:28:38 UTC
All but one test should be fine now (test 8).  I'll attach a proposed patch
(adding "-u" option to intltool-merge in selftest.pl.in, and correcting
results/merge5p.sheet) to fix that as well.
Comment 4 Danilo Segan 2004-06-14 09:31:55 UTC
Created attachment 28682 [details] [review]
Fix test 8: merging translations into Dia-style XML file

2004-06-14  Danilo Šegan  <dsegan@gmx.net>

	* tests/results/merge5p.sheet: Make it correct UTF-8.
	* tests/selftest.pl.in (check_merge_result): Use "-u" in test 8.

	Fixes bug #138512.
Comment 5 Kenneth Rohde Christiansen 2004-06-14 09:44:38 UTC
please commit
Comment 6 Danilo Segan 2004-06-14 10:27:02 UTC
Comment on attachment 28682 [details] [review]
Fix test 8: merging translations into Dia-style XML file

Comitted to HEAD.
Comment 7 Danilo Segan 2004-06-15 09:11:49 UTC
Reopening: I'll need to look into test 18 again, it seems to fail occasionally
(it passes for me, which is why I closed the bug).
Comment 8 Danilo Segan 2004-06-15 17:49:21 UTC
I've posted another patch for intltool-merge on bug 46650.  As for the test
itself, check_merge_results is not really suited for --multiple-output (at least
so it seems, since it compares cases/merge6.xml with results/merge6.xml instead
of comparing merge6/merge6.xml with results/merge6/merge6.xml -- the latter
doesn't exist, the first is produced when running "intltool-merge -m").

I'll fix all that once the new patch in 46650 is committed.
Comment 9 Danilo Segan 2004-06-16 23:07:14 UTC
I've created new tests for multiple-output merging. "make distcheck" and "make
check" both pass for me now, so I'm closing the bug.