After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 137314 - Shuffle doesn't update the number of moves available
Shuffle doesn't update the number of moves available
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: mahjongg
2.5.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
: 139334 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-03-16 00:41 UTC by Iain
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
It updates the move counter when you shuffle... (948 bytes, patch)
2004-03-16 01:07 UTC, Iain 		none Details | Review

Description Iain 2004-03-16 00:41:18 UTC 
When shuffling the tiles, the number of moves available only gets updated
when you make your next move, so when you get the "No more moves available"
dialog and click shuffle, the counter stays at 0 even if there are moves.
Comment 1 Iain 2004-03-16 01:07:16 UTC 
Created attachment 25681 [details] [review]
It updates the move counter when you shuffle...
Comment 2 Iain 2004-03-16 01:08:44 UTC 
Okay, so I got bored and worked out this massive patch...

Then I noticed it was a one line fix.
Comment 3 Callum McKenzie 2004-03-16 01:12:38 UTC 
OK, I'll apply this when I get home.
Comment 4 Callum McKenzie 2004-03-16 06:17:48 UTC 
Applied. Expect to see it in CVS soon.
Comment 5 Callum McKenzie 2004-04-14 05:47:48 UTC 
*** Bug 139334 has been marked as a duplicate of this bug. ***
Comment 6 Colin Macdonald 2004-04-14 07:19:05 UTC 
This isn't fixed in 2.6.0.1 on my system (Gentoo GNU/Linux ~x86)

I also posted in Bug 139334 and thats closed too.  Maybe I will open a new bug
as I'm not sure poking closed bugs gets noticed...
Comment 7 Richard Hoelscher 2004-04-14 14:50:14 UTC 
Colin: If you need to see this bug fixed in gnome-games-2.6.0.1, notify Gentoo's
maintainers of the GNOME packages about this patch. They can add it to the
ebuild so that it is applied to 2.6.0.1 source after the tarball is unpacked and
before it is built. That's what Gentoo is all about, and it's done all the
time... even though it is a reliable source of NOTGNOME bugs.
Comment 8 Colin Macdonald 2004-04-14 18:52:26 UTC 
Richard: Thanks I understand that (I did check that gentoo wasn't patching the
source before I mentioned that it wasn't fixed in 2.6.0.1), just wanted to make
sure that this got reexamined of 2.8 as Callum's comments seemed to indicate it
was fixed in 2.6.0 (at least in 139334).  Its not a major thing but I'll go
mention it to the gentoo folk as per your suggestion.
Comment 9 Callum McKenzie 2004-04-14 22:53:41 UTC 
Reopening because I should apply this to the 2.6 branch. Sorry for the confusion.
Comment 10 Callum McKenzie 2004-04-15 07:52:27 UTC 
Fixed in gnome-2-6 too, it should appear in 2.6.1, whenver that is.
Comment 11 Callum McKenzie 2004-04-15 07:52:56 UTC 
Fixed in gnome-2-6 too, it should appear in 2.6.1, whenever that is.