After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 136117 - Highlight which part of equation is causing error
Highlight which part of equation is causing error
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
unspecified
Other opensolaris
: Normal enhancement
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2004-03-03 22:21 UTC by Rich Burridge
Modified: 2012-10-14 00:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Highlight which part is causing error. (31.23 KB, patch)
2012-10-07 21:09 UTC, PioneerAxon 		committed Details | Review
Highlight which part is causing error. (31.23 KB, patch)
2012-10-07 21:22 UTC, PioneerAxon 		none Details | Review

Description Rich Burridge 2004-03-03 22:21:21 UTC 






Comment 1


Rich Burridge





          2004-03-03 22:21:58 UTC
        



Pressed the Send key too soon...

Would be really cool if the error reporting could be improved
somehow, e.g. to highlight in the display where exactly the expression
parsing broke down, rather than just showing "Malformed expression" in
the status bar.







Comment 2


PioneerAxon





          2012-10-07 21:09:51 UTC
        



Created attachment 226004 [details] [review]
Highlight which part is causing error.






Comment 3


PioneerAxon





          2012-10-07 21:22:40 UTC
        



Created attachment 226006 [details] [review]
Highlight which part is causing error.






Comment 4


PioneerAxon





          2012-10-07 21:24:04 UTC
        



Oops!! There was an Internal Server error, when I first submitted it.. :/
Never mind.






Comment 5


Robert Ancell





          2012-10-07 21:41:11 UTC
        



Review of attachment 226004 [details] [review]:

Just minor whitespace changes but otherwise looks good, thanks Arth!

::: src/lexer.c
@@ +16,3 @@
         return FALSE;
     }
+    if((*(state->parent->function_is_defined))(state->parent, name))

Accidental whitespace changes (more in this file)






Comment 6


Robert Ancell





          2012-10-07 21:46:50 UTC
        



Some good examples:
unknownvariable
192+abc+102
11ab45+3






Comment 7


PioneerAxon





          2012-10-08 10:28:52 UTC
        



Sorry for the whitespace changes. I came across them while looking at the code. Hence fixed it in the same patch.

Some more examples are
12⁻
1+12.