GNOME Bugzilla – Bug 135084
'Add Wallpaper' button opens 'Add Wallpapers'
Last modified: 2004-12-22 21:47:04 UTC
As per title really :) The 'Add Wallpaper' button opens up a dialogue box entitled 'Add Wallpapers'. The button text should probably be changed to 'Add Wallpapers' since more than one wallpaper can be added.
Jody, Kjartan, since the string is already around, would this break stringfreeze?
I would break the freeze and I think it's such a minor nitpick that it can wait until the next cycle, or at least until after 2.6.0 (if we are thawing the freezes then)
so, it's not a string freeze breaking patch since the "new" string is already in there and marked for translation, but still, not sure if it's worth it...
I know that I spent a few minutes selecting files, one by one, to be added to my wallpapers. With each click I was cursing the fact that I could only add one at a time. Only then did I realise that more than one file is selectable at once. I do think the button's text should be changed to "Add wallpapers" ASAP.
It should be "Add Wallpaper" ideally. "Wallpaper" is an inherently plural term, and doesn't need the 's' appended to it, to make it one. I don't know why I put an s in one place and not the other. Probably was a stupid little typo. I'm removing the GNOMEVER2.7 keyword though, and moving this to the 2.6.1 milestone. I'll fix it then. As Kjarten said, I don't think it is overly important for 2.6.0 either. There is a much larger, more important change waiting for acceptance for 2.6.0, than a simple one character removal. (For what it's worth, you can also just open a Nautilus window, select all of the images you want to add, and drag them to the capplet, also.)
Fixed in CVS.
Changing to "Add Wallpaper" broke the string freeze...
How did it break the string freeze? The string, "Add Wallpaper" was already in the glade file and thus should have been translated already.
Nope, it wasn't. As Kjartan pointed out, the string "Add Wallpapers" was already in the Glade file, and changing to that string wouldn't break the freeze. But you changed to a different string, "Add Wallpaper", which hence broke the freeze.
Reopening this. Kjarten and I discussed this on IRC. The string "_Add Wallpapers" is not translated though, so changing the button text would still also break the string freeze. So, I guess this will have to wait for 2.8, unless i18n and release-team want to approve this for 2.6.x.
This is fixed in HEAD for 2.7/2.8.