After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 133782 - Use HIG recommendation for ellipses in context menus
Use HIG recommendation for ellipses in context menus
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: general
git master
Other All
: High normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks: 131223
 
 
Reported: 2004-02-08 12:17 UTC by spark
Modified: 2005-08-15 01:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch that removes extraneous ellipses (30.09 KB, patch)
2004-02-08 21:51 UTC, alexander.winston
none Details | Review
Here is the patch for the applets in the gnome-panel module. (7.75 KB, patch)
2004-02-12 03:44 UTC, Dennis Cranston
accepted-commit_now Details | Review
Here is the patch for the gdict applet in the gnome-utils module. (1.55 KB, patch)
2004-02-12 03:45 UTC, Dennis Cranston
none Details | Review
Here is the patch for the gnome-netstatus module. (1.47 KB, patch)
2004-02-12 03:46 UTC, Dennis Cranston
accepted-commit_now Details | Review

Description spark 2004-02-08 12:17:40 UTC
Currently, most (all?) the applets don't adhere to the HIG's recommendation
for ellipsizing menu entries in their context menus: they all have:

"Preferences..."
"About..."


The HIG link for ellipsizing:

http://developer.gnome.org/projects/gup/hig/draft_hig_new/menus-design.html#menu-item-types

"Label the menu item with a trailing ellipsis ("...") only if the command
requires further input from the user before it can be performed. Do not
add an ellipsis to items that only present a confirmation dialog (such 
as Delete), or that do not require further input (such as Properties, 
Preferences or About)."
Comment 1 alexander.winston 2004-02-08 21:51:49 UTC
Created attachment 24211 [details] [review]
Patch that removes extraneous ellipses
Comment 2 spark 2004-02-09 09:20:20 UTC
Quick off the mark with the patch! Can this make tonight's string 
freeze?
Comment 3 Dennis Smit 2004-02-10 15:44:37 UTC
This should get in, can i still submit it on time or should
we go through the release team ?, the faster the better.
Comment 4 Kevin Vandersloot 2004-02-11 14:00:19 UTC
Hmm, it seems like it was usability people who originally approved the
ellipsation of the menus ;)

Someone will have to email for permission from gnome-i18n list and
release team. It would be nice to also get a usability person to
confirm this is what we want.
Comment 5 Dennis Smit 2004-02-11 23:34:47 UTC
I have no experience with neither the i18n or usability team. 
Could someone who has contact them ?
Comment 6 alexander.winston 2004-02-12 03:13:18 UTC
Adding <mailto:usability-maint@bugzilla.gnome.org> to the CC list at
the request of Bryan Clark and moving priority to high.
Comment 7 Dennis Cranston 2004-02-12 03:44:16 UTC
Created attachment 24334 [details] [review]
Here is the patch for the applets in the gnome-panel module.
Comment 8 Dennis Cranston 2004-02-12 03:45:17 UTC
Created attachment 24335 [details] [review]
Here is the patch for the gdict applet in the gnome-utils module.
Comment 9 Dennis Cranston 2004-02-12 03:46:08 UTC
Created attachment 24336 [details] [review]
Here is the patch for the gnome-netstatus module.
Comment 10 Kjartan Maraas 2004-04-28 20:03:07 UTC
String changes should go in after branching.
Comment 11 Dennis Smit 2004-06-07 15:15:48 UTC
Ok i want to get this in, shall we procceed as following:

Submit the patch for gnome-applets
fill bugs for the other components and ask the maintainer
to merge the patch for theirs as well ?
Comment 12 Bryan W Clark 2004-06-09 22:25:33 UTC
Yes, this sounds like a good plan, it'd be great to get this one done.
Comment 13 Dennis Smit 2004-06-10 23:42:00 UTC
Submitted to gnome-applets, thanks a lot for the patch:

Not closing yet because of the other patches.

___
2004-06-11  Dennis Smit  <ds@nerds-incorporated.org>

        Removed ellipses in context menus.

        Based on the patch by:
        Alexander Winston  <alexander.winston@comcast.net>

        Fixes bug: #133782.

Comment 14 Dennis Smit 2004-06-10 23:50:36 UTC
I will be filling bugs in the netstatus and panel components for
the other two patches.


___
2004-06-11  Dennis Smit  <ds@nerds-incorporated.org>

        * GNOME_GDictApplet.xml:
        Remove from ellipsizing per HIG.
        Fixes gnome-utils part of bug #133782.

        Patch by: Dennis Cranston  <dennis_cranston at yahoo com>

Comment 15 Dennis Smit 2004-06-11 00:00:58 UTC
Bugs filled for the netstatus applet and panel:

Panel:      #144130
Netstatus:  #144131
Comment 16 Dennis Smit 2004-06-11 11:08:51 UTC
Cheers, everything is in!

Thanks a lot Dennis and Alexander!