After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 132908 - Screenshooter uses old GtkFileSel instead of GtkFileChooser
Screenshooter uses old GtkFileSel instead of GtkFileChooser
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: panel
2.4.x
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on: 132043
Blocks: 129568
 
 
Reported: 2004-01-29 20:53 UTC by Seth Nickell
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Seth Nickell 2004-01-29 20:53:49 UTC
It would be good to use GtkFileChooser consistently in GNOME 2.6 instead of
having mixed widgetry.
Comment 1 Fernando Herrera 2004-02-01 19:35:48 UTC
gnome-panel-screenshot uses GnomeFileEntry, that uses old gtk
fileselector. The problem, as you can see in bug #132043 is that that
widget cannot be updated without breaking the API/ABI or doing a ugly
hack (implement both selectro and chooser and use one or other cheking
a flag,  for example).
Some others apps using this widget have the same problem.
A possible solution would be use a different widget (GtkEntry + Button
+ GtkFileChooserDialog?)
Comment 2 Fernando Herrera 2004-02-09 19:33:11 UTC
With the patch Carlos did on bug #132043 (plus glade register) this
will be as simple as:

diff -u -u -r1.14 gnome-panel-screenshot.glade
--- gnome-panel-screenshot.glade        23 Nov 2003 20:24:05 -0000   
  1.14
+++ gnome-panel-screenshot.glade        9 Feb 2004 19:31:09 -0000
@@ -266,6 +266,7 @@
                              <property name="max_saved">10</property>
                              <property
name="directory_entry">False</property>
                              <property name="modal">False</property>
+                               <property
name="use_filechooser">True</property>
  
                              <child internal-child="entry">
                                <widget class="GtkEntry" id="save_entry">

Comment 3 Mark McLoughlin 2004-02-10 15:44:23 UTC
As soon as the libglade and libgnomeui patches go in, feel free to
commit this ... requiring the new version of libglade of course ...
Comment 4 Fernando Herrera 2004-02-10 21:13:21 UTC
The patch was only to libgnomeui (and their glade stuff in gnome-glade.c).
Committing this. Change gnome-panel to requiere libgnomeui >= 2.5.4
(just now it needs the cvs HEAD). The patch to glade-2 for editing
this property graphically is waiting for approval.