After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 132851 - Keyboard Indicator applet breaks panel keynav
Keyboard Indicator applet breaks panel keynav
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: keyboard indicator (gswitchit)
git master
Other All
: Normal major
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
AP1
Depends on:
Blocks:
 
 
Reported: 2004-01-29 14:14 UTC by bill.haneman
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (775 bytes, patch)
2004-01-30 09:36 UTC, padraig.obriain 		none Details | Review

Description bill.haneman 2004-01-29 14:14:15 UTC 
the Keyboard Indicator applet (I refer to gnome-keyboard-applet, not the
old gkb) seems to be a black hole for panel keynav; once it's focussed, you
can't get out via Ctrl-TAB, Shift-TAB, or TAB to move to other panel items.
Comment 1 bill.haneman 2004-01-29 14:15:20 UTC 
marking AP1 since this applet is used in most non-English only
settings, and its use defeats other panel keynav.
Comment 2 bill.haneman 2004-01-29 14:15:53 UTC 
I believe Padraig is investigating.
Comment 3 padraig.obriain 2004-01-29 16:32:18 UTC 
Normally when you tab out of an applet the applet's GtkPlug sends an
XEMBED_FOCUS_NEXT or XEMBED_FOCUS_PREV message to the GtkSocket in the
panel.

In this case this message is not being set. Need to find out why.
Comment 4 padraig.obriain 2004-01-29 16:54:44 UTC 
When focus_to_parent is called in gtkplug.c, plug->socket_window is
NULL. This explains why the message is not getting back to the panel.

Nede to figure out why plug->socket_window is NULL>
Comment 5 padraig.obriain 2004-01-30 09:36:43 UTC 
Created attachment 23891 [details] [review]
Proposed patch
Comment 6 padraig.obriain 2004-01-30 09:39:54 UTC 
plug->socket_window should be set in gtk_plug_filter_func when a
ReparentNotify event is received. The problem is that gswitchit-applet
has defined a filter function and it does not return
GDK_FILTER_CONTINUE for a ReparentNotify.
Comment 7 padraig.obriain 2004-02-05 18:16:49 UTC 
Sergey,

Can you approve this patch?
Comment 8 Sergey V. Udaltsov 2004-02-05 20:51:56 UTC 
I think you can submit it - as long as it really fixes the problem. Thanks
Comment 9 padraig.obriain 2004-02-06 08:50:56 UTC 
Patch committed to CVS HEAD.