After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 132543 - Patch implementing NO_RAISE_ON_FOCUS mode
Patch implementing NO_RAISE_ON_FOCUS mode
Status: RESOLVED DUPLICATE of bug 86108
Product: metacity
Classification: Other
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2004-01-26 10:23 UTC by Martin Grimme
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
the patch for NO_RAISE_ON_FOCUS (7.56 KB, patch)
2004-01-26 10:24 UTC, Martin Grimme
none Details | Review
same patch as above, just fixed a typo (6.94 KB, patch)
2004-01-26 10:47 UTC, Martin Grimme
none Details | Review

Description Martin Grimme 2004-01-26 10:23:38 UTC
A comment in display.c says:
/* Raise on clicking the client area always or only
 * in click to focus mode? The debate rages.
 * Feel free to change TRUE to FALSE or vice versa
 */

By user request I have implemented a NO_RAISE_ON_FOCUS mode for metacity.
If that mode is activated, windows receiving the focus don't get raised
automatically.
This is basically a GConf switch for the TRUE/FALSE debate from the
comment above.

Please review the patch. It applies to CVS HEAD.


Thanks,
Martin Grimme
Comment 1 Martin Grimme 2004-01-26 10:24:32 UTC
Created attachment 23756 [details] [review]
the patch for NO_RAISE_ON_FOCUS
Comment 2 Martin Grimme 2004-01-26 10:47:44 UTC
Created attachment 23757 [details] [review]
same patch as above, just fixed a typo
Comment 3 Dave Bordoley [Not Reading Bug Mail] 2004-01-27 04:06:15 UTC
Well i usually don't like to close other maints bugs, but in this case
i'm fairly certain that havoc is going to want to actually implement
the wm_spec for this feature which prevents focus stealing on map when
a window is accepting input instead of adding a pref. so marking this
a dupe of that bug.

*** This bug has been marked as a duplicate of 118372 ***
Comment 4 Elijah Newren 2004-01-27 04:28:06 UTC
This isn't a duplicate of bug 118372.  The description sounds sort of
like it, but the description is misleading.  What the patch implements
is a do-not-raise-on-click option, not a do-not-raise-on-focus option
(raising may be equivalent to clicking in click-to-focus mode, but it
isn't for sloppy/mouse focus modes).  This option isn't something
Havoc is going to accept until people have tried alternative
intermediate behaviors--e.g. raise on click normally but not when the
action is part of a drag and drop operation.  There are many bugs
about this, see bug 86108, bug 115072, bug 115753, or bug 131135 for
more information.

I'm reopening and marking as a duplicate of 86108.
Comment 5 Elijah Newren 2004-01-27 04:28:30 UTC

*** This bug has been marked as a duplicate of 86108 ***
Comment 6 Dave Bordoley [Not Reading Bug Mail] 2004-01-27 05:42:02 UTC
oops sorry elijah...
Comment 7 Elijah Newren 2004-01-27 18:00:15 UTC
David: no worries.  :-)  I just didn't want someone else running
across the bug and getting confused, or having Martin misunderstand
your comment and then be surprised when his functionality wasn't
becoming part of Metacity, so I thought I'd try to clear things up.  I
can easily see how these two could be confused (in fact, if I hadn't
also made a patch for do-not-raise-on-click similar to Martin's a
little while ago, I probably wouldn't have seen the difference either
until I tried to figure out how it would help me implement bug 118372).