GNOME Bugzilla – Bug 132311
fixed-height mode should work for GTK_TREE_VIEW_COLUMN_GROW_ONLY
Last modified: 2006-05-27 22:31:08 UTC
Apart from the current checks, the fixed-height code works fine for GTK_TREE_VIEW_COLUMN_GROW_ONLY. Please change the checks to allow this. (GTK_TREE_VIEW_COLUMN_FIXED is a pita, really.)
Created attachment 24768 [details] [review] Brutally simple fix
I don't see how this could work. Just removing the checks doesn't make the problem go away. You'll get columns resizing during scrolling or not growing at all with this.
> You'll get columns resizing during > scrolling or not growing at all with this. ...which is how _GROW has behaved for ages: it sizes the first 500 rows. (If idle it'll do the rest later.) I don't see that as a problem. Admittedly the patch is a bit too brutal. It should probably check for _AUTO here and there.
Created attachment 25340 [details] [review] Realistic patch
The problem I'm complaining about is that I think you'll get the column resizing during scrolling, not during an idle. Anyway, I'm not going to get to it until after 2.4.0, so we can try it out afterwards. (-;
Nominating for 2.4.2. (You can get resizing during scrolling with plain _GROW also. Just make 10^6 lines of same small length and a final, longer line. Show it and scroll to the end --> resize.) This patch makes a lot of difference for Gnumeric's search center and text import.
Created attachment 27671 [details] [review] Updated patch Recent changes made the previous patch not apply cleanly. This one does.
Mass changing gtk+ bugs with target milestone of 2.4.2 to target 2.4.4, as Matthias said he was trying to do himself on IRC and was asking for help with. If you see this message, it means I was successful at fixing the borken-ness in bugzilla :) Sorry for the spam; just query on this message and delete all emails you get with this message, since there will probably be a lot.
Clearing target milestone -- this belongs somewhere in the 2.5 series.
What it blocking this patch from going in?
I fully agree with Jonathan here, this is not going to work. The width of GROW_ONLY columns is mainly decided by their requested_width, which is not kept up to date in fixed height mode. You'll just have to use FIXED columns with a nicely chosen width, you (or the user) can resize them just fine later on if needed.