GNOME Bugzilla – Bug 130782
UI enhancement in overwrite dialog
Last modified: 2007-12-20 07:28:07 UTC
The following actions are missing in the overwrite track dialog : -cancel ripping -ignore all -overwrite all
Better yet, detect the case where all tracks are already ripped and the files of plausible size and say "you already ripped this CD, do you really want to do it again?"
Created attachment 36679 [details] [review] The patch adds the actions like Overwrite All , Ignore All & Cancel Ripping in the Overwrite Dialog.
Comment on attachment 36679 [details] [review] The patch adds the actions like Overwrite All , Ignore All & Cancel Ripping in the Overwrite Dialog. I'd prefer the mode to be a static variable in sj-extracting.c and the types to be an enum.
Created attachment 37088 [details] [review] this is a slightly modified patch in which the mode is a static variable in sj-extracting.c and the types is changed to be enum
*** Bug 169465 has been marked as a duplicate of this bug. ***
Sadly this patch has bit-rotted as it need to use gnome-vfs.
*** Bug 366342 has been marked as a duplicate of this bug. ***
Created attachment 98951 [details] [review] Add skip all / overwrite all This drives me crazy... so here's an updated patch. I think it's clearer than the previous versions. If it's OK, I have commit access. - Mike
Created attachment 98952 [details] [review] Add skip all / overwrite all, correctly Minor correction of previous patch.
Getting there, but gtk_dialog_run() can return GTK_RESPONSE_DELETED if it is closed by the window manager. You'll have to handle that (and default: just for good measure) in the case statement, I guess as Overwrite (but I'd take arguments for why it should be something else).
Created attachment 99066 [details] [review] overwrite/skip all
New patch above, adding default: and GTK_RESPONSE_DELETE_EVENT: explicity. I made the default "skip" rather than "overwrite"- it feels more natural to me that way (i.e., if you close the dialog, it safely does nothing, rather than overwriting existing data). - Mike
Thanks, please commit to trunk.
Committed to svn rev 1901. - Mike
Hmm... trunk is marked as string frozen at http://l10n.gnome.org/module/sound-juicer... in which case this patch breaks the string freeze. ?
Doh, I forgot to branch. One minute and I'll fix that. :)
*** Bug 504589 has been marked as a duplicate of this bug. ***