GNOME Bugzilla – Bug 129956
For locales with non "." radix predefined constants not properly initialized
Last modified: 2004-12-22 21:47:04 UTC
Description of Problem: Steps to reproduce the problem: 1. LANG=ru_RU.KOI8-R gcalctool 2. Check [Con] button 3. Actual Results: 2 for E, 3 for PI etc. Expected Results: 2,71828.. for E, 3,14159.. etc How often does this happen? Always.
Created attachment 22688 [details] [review] Proposed patch
Adding PATCH keyword.
Changing the category to put on Rich's radar. Thanks for the patch.
Actually, this looks like a variant of bug #130282. The proposed patch isn't the correct fix as "." isn't always the radix character. It's a locale dependent thing.
This is not variant of bug #60683. The proposed patch is correct fix since you have "." as radix in hardcoded strings. It temporary swaps actual locale radix with "." just to let those strings be parsed.
Just substituting "." for the radix character does not solve the problem that the constants should be displayed in the Con menu with the correct radix character. Bug #128603 is currently discussing the best way to fix that. Fix #128603 and I believe this problem will go away. Your proposed solution is not a real fix for this problem as the constant strings need to display the correct radix character.
If you apply this patch you probably understand how it works. And will see Con menu filled with proper values. They will include *current locale* radix. Btw making this strings localizable is very bad idea. This looks for me just like making yet anothere place where bugs may come.
You're right. The patch will allow constants to be displayed with the locale radix char. I'll still need the patch from bug #128603 though, for the read-only memory problem. I agree with you about not localising the constant strings. I'll check these fixes in tomorrow. Thanks.
The last attachment to bug #130282 has a similar fix plus more, so I'm closing this out as a dup. of that bug. *** This bug has been marked as a duplicate of 130282 ***