GNOME Bugzilla – Bug 129704
Request Undo/Redo functions
Last modified: 2004-12-22 21:47:04 UTC
I have been using mlview for a week and never noticed that it has no undo/redo functions. i accidently deleted a paragraph and now have no way of getting it back(well, i do have a backup copy). the bummer is that, what if i didn't write the paragraph because the document was being written by multiple people? i would have no idea what to rewrite. also, it would be really nice if there were text wrapping. the real benefit to having this feature is that when multiple people are contributing to a document the formatting for the xml file becomes inconsistent. this is especially true for large areas of text. it seems everyone has differing opinions on how many tabs to use, how many characters til the start of the next line, whether they even use next lines (i like to not have carriage returns in the text). another useful feature would be displaying the cursor position, line number, etc. knowing how many characters are on the current line can also help to keep the formatting consistent. Finally, i would like to say thanks for a great app. it is very user-friendly and intuitive, however, the greatest thing is its simplicity. i will use mlview for my xml docs from now on. scott
Hi Scott, Thank you for your nice feature request ;) Concerning the undo/redo, yes, this is something I would like to work on. I am a bit busy in working on the some other features at the moment, but be sure that undo/redo is something I really want to see happen. The text wrapping feature request is something I would like some more information about. In which widget do you want to see that happen ? In the tree editor widget or in the node editor widget (the widget at the bottom of the editor) ? I have a couple of other questions to ask concerning this, but I'll let you answser this one first ;) Thank you very much for your time and effort. Dodji.
Bonjour Dodji, thanks for the quick reply! Concerning text wrapping: i think it is more important in the short term that the node editor have wrapping. however, the tree editor would also be more intuitive with text wrapping. i guess the way i look at it, the user should be so happy with the way the information is displayed, that they forget all about trying to format it. kind of a "let the app fit the user" philosophy. another benefit to having text wrapping options is that with wrapping on, horizontal scrolling widgets in the tree editor could be made to display only when necessary, like in highly nested docs. with wrapping on in the node editor, horizontal scrolling would not even be necessary. having scrollbars show up dynamically frees up precious real estate, and the user sees more of their code. : o ) i think the logical place for these options would be in an "Edit -> Preferences" option. so early in development, it would be easy to start maintaining GNOME HIG compliance: http://developer.gnome.org/projects/gup/hig/ > I have a couple of other questions to ask concerning this, > but I'll let you answser this one first ;) ask away, i am more than happy to help with my opinions/thoughts. feel free to contact me directly at my email address or keep posting here. > I am a bit busy in working on the some other features > at the moment, but be sure that undo/redo is something > I really want to see happen. i would be interested in hearing these features... > Thank you very much for your time and effort. > Dodji. Thank YOU very much ;) scott
Hey hey Scott, I have finally coded the undo/redo feature. It's available in the GNOME CVS HEAD. 90% of the editing action can now be undoed. Any feedback would be greatly appreciated. I will keep this enhancement request opened untill mlview 0.7.0 is released. Thank you for reading. Dodji.
Awesome, it works great! Maybe the buttons should use the user's options for button text placement. I'll attach a screenshot of MLView 0.7.0(prerelease) and gedit showing the undo/redo buttons. Notice how the button text for gedit buttons all follow the gnome user preferences set using gnome-ui-properties. Also, I started another bug report called "Text Node - not properly updating the main window" Thanks so much for adding undo/redo capability!!! scott
Created attachment 30564 [details] mlview undo/redo button text placement
Created attachment 30565 [details] gedit undo/redo button text placement
Hey hey Scott ! Oh, yeah, you are right, there is something not going well in the button text placement handling. I'll have a look at that. Also, I am refactoring the overall menu/toolbar handling in the editor. I'll find sometime to drop a mail about this to the list later. Cheers, Dodji
Hi Scott, the undo/redo button text placement bug seems to be fixed in CVS HEAD and in mlview--mainline--0.7 now. Thank you for reporting this. Dodji.