GNOME Bugzilla – Bug 129397
gcalctool should use gnome-icon-theme
Last modified: 2004-12-22 21:47:04 UTC
gcalctool should use the gnome-icon-theme icon instead of a built-in one. Attached is a patch to do so. With this patch, the gcalctool/gcalctool/gcalctool.png image can be CVS removed, as it is no longer needed.
Created attachment 22469 [details] [review] Proposed patch
Yes it should (and thanks for the patch), but if I check this in now, it will create a dependancy on the latest tk+ which I'm not prepared to do at the moment. Hopefully soon though.
adding PATCH keyword
Hi Michael, I just tried applying your patch and am getting the following error at build time: ... gmake[3]: Nothing to be done for `all-am'. gmake[3]: Leaving directory `/net/stard/space/richb/gnome-2.4/gcalctool/help' gmake[2]: Leaving directory `/net/stard/space/richb/gnome-2.4/gcalctool/help' gmake[2]: Entering directory `/net/stard/space/richb/gnome-2.4/gcalctool' gmake[2]: *** No rule to make target `gcalctool.desktop', needed by `all-am'. Stop. gmake[2]: Leaving directory `/net/stard/space/richb/gnome-2.4/gcalctool' gmake[1]: *** [all-recursive] Error 1 ... Is there some change needed to the top-level Makefile.am to fix this problem?
Hmm.. Just tried it over here and it worked for me. I would be very surprised if this is due to my patch, because I don't change how gcalctool.desktop is handled by the toplevel Makefile.am. I only change what icon gcalctool.desktop.in uses.
Yeah, I think you're right. I suspect I haven't got a proper GNOME 2.6 build environment setup on my Solaris box at work. Okay, thanks for looking into it. I'll go ahead and commit the patch.
Changes checked into CVS HEAD. Version number in configure.in bumped to 4.4.6. Thanks!