After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 129316 - Opening OpenPGP message crashes Balsa CVS
Opening OpenPGP message crashes Balsa CVS
Status: RESOLVED FIXED
Product: balsa
Classification: Other
Component: general
2.0.x
Other All
: Normal critical
: ---
Assigned To: Balsa Maintainers
Balsa Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-12-14 14:10 UTC by albrecht.dress
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.3/2.4


Attachments
patch to resolve this bug (6.65 KB, application/octet-stream)
2003-12-14 14:11 UTC, albrecht.dress
Details

Description albrecht.dress 2003-12-14 14:10:51 UTC
Symptom:
========
Balsa displays a broken message and/or crashes when opening an OpenPGP
(RFC2440) signed and/or encrypted message.


Reason:
=======
Wrong parameter passed to a subroutine in src/balsa-message.c


Fix:
====

The patch below (against the cvs of Dec 14, 2003) fixes this bug (file
src/balsa.message.c) plus the following ones:

* potentially critical:
If the passphrase cash is enabled, it is not erased when balsa exits
normally. This might leave the encrypted passphrase in RAM until the
machine is restarted or the RAM is used again. The fix to
libbalsa/rfc3156.c takes care of overwriting the memory with random crap.

* cosmetical:
construct the key selection and passphrase entry dialogs according to the
HIG (mostly at least). To this end, I also added a new icon (file
libbalsa/padlock-keyhole.xpm) which according to a discussion in the hig is
supposed to move into mainstream gtk+ (stolen from there), so it might be
removed and replaced by a stock icon later.
Comment 1 albrecht.dress 2003-12-14 14:11:43 UTC
Created attachment 22434 [details]
patch to resolve this bug
Comment 2 Pawel Salek 2003-12-15 09:19:38 UTC
Commited. Thanks!