GNOME Bugzilla – Bug 128774
"Edit exchange rate" context menu item disfunctional often
Last modified: 2018-06-29 20:39:32 UTC
Most of the time, whenever gnucash thinks that it doesn't make sense, the "Edit exchange rate" context menu item for a transaction (in the register) doe snothing at all. No reaction at all. There are 3 problems with that: 1. The user is confused about what's wrong and concludes that the software is broken here. 2. Obviously, the user tried to do something. Guess what he tried to do and at least pop up a dialog, telling him *why* it doesn't work and what he could/should do instead. 3. Many times, it in fact should work. Problem 3 in detail: If I transfer money from a EUR income account to a US-$ bank account (with EUR being by default currency), I should be able to select the transaction in the EUR income account and edit the exchange rate from there. GnuCash just ignores my request. It works, if I do the same from the US-$ bank account side of the same transaction. Makes no sense to me and is bad UI. Also see bug 128771.
This is still an issue in 1.9.2. Probably, the 'edit exchange rate' menuitem should be insensitive when it won't do anything. Note that this is not the same as the 'transfer' button (which uses the same dialog) which should always be sensitive.
The logic to determine whether there is an exchange rate dialog to be showed is complex and should not run when you user traverses her register. The attached patch adds a bit more information for the user where this logic previously silently returned without action. Adding Christian as active dev and the one deciding whether these strings are worth to be added to the pool of i18n'ed strings :-)
Created attachment 118780 [details] [review] First try
Re comment 2: Just ignore all i18n issues. The error is severe enough to ignore them for now, i.e. feel free to back-port this changes. Committed the patch to trunk as r17654.
2.2-branch, r17734
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=128774. Please update any external references or bookmarks.