GNOME Bugzilla – Bug 127874
The edge for resizing columns is wrong in rtl-oriented GtkTreeView
Last modified: 2004-12-22 21:47:04 UTC
# This bug report is concerned with Bug #127581. When the user change the width of a column, the drag position should be the left edge of the button in rtl-oriented GtkTreeView. But it isn't. The detail of the bug is the following: [Steps to Reproduce] 1. Run testtreeview program in ./test directory on bidi locale. (e.g. he_IL) 2. Set "resizable" property of some columns. 3. Try to resize one of them. You'll find the drag position is placeed at the right edge of the button. <-- Problem! [Actual Results] Drag position is placed at the right edge of button. When we try increase width of column, it is decreased, and vice versa. [Expected Results] Drag position should be placed at the left edge of button. Button should be resized correctly.
Here is a patch for this bug. (It was created by the source in CVS on 2003/Nov/19) http://www-124.ibm.com/linux/patches/?patch_id=1211 To apply this patch, the patch for Bug #127581 is also necessary. http://www-124.ibm.com/developerworks/oss/linux/patches/?patch_id=1189 Thanks in advance
As the former patch has a lack, We updated the patch. Please try gtktreeview-changewidth-20031126.patch.gz at the URL which I wrote in last comment. Thank you,
Can you attach the patches instead of posting a URI in the future? URIs tend to get lost over time.
Created attachment 21871 [details] [review] Patch based on CVS 2003/Nov/26
Excuse me for your time. I'll submit patches directly here in future.
No worries. Attaching the patch is more for future reference than for me right now. There are just a good number of bugs in bugzilla with patches that are 404, so it's good to attach when possible so that we always have a record. Some comments on the patch itself: * We don't use C++ style comments in GTK+ anywhere. I removed all of them. * As a minor style quible, I'd prefer to do ternary operations as this: expr ? (a) : (b); With the spaces around the ? and the : * We tend to use rtl instead of isRTL as the variable for testing rtl. Anyway, I'm applying a slightly modified version to HEAD and to the 2.2 branch. I'm attaching the final version of the patch.
Created attachment 21916 [details] [review] rtl patch
Thanks for fixing this issue! I verified this issue was fixed. If we submit patches in future, we'll make them according to your comments. Thanks again.
I found my e-mail address in ChangeLog. However, Semion Chichelnitsky created the patch I attached. Could you please replace my address with <semion@il.ibm.com>? As IBM manage patches strictly, he could not submit patches directly. Therefore, I checked his code and I submited the patch as his proxy. Thanks for your time.