GNOME Bugzilla – Bug 126176
need UI for GOK's 'auxiliarly wordlist'
Last modified: 2004-12-22 21:47:04 UTC
GOK can now use a user-defined (or sysadmin-defined) auxiliarly wordlist for its word completion in addition to the GOK dictionary. There are 2 gconf keys controlling this, /apps/gok/use_aux_dicts (boolean) and /apps/gok/aux_dictionaries (semicolon-delimited path list). I think we need to connect these to some UI for gnome-2.6. Feature/UI freeze is end-December I think.
David, can you take this? You might check with Calum with respect to the UI/usability of the resulting dialog.
Sure.
I may not get to this immediately.
Adding Calum as a QA contact for this HIG related work.
Created attachment 21623 [details] a screenshot showing the road i am thinking of travelling...
Calum, I am thinking that the list will display full paths to word completion files. Addition can be done by hand (or by browsing which i haven't added yet), and removal can be done with the delete key. Is this suitable?
With a list of items, it's more usual to have explicit Add and Remove buttons, that pop up a file browser or deleted the selected item(s) respectively. I'd be pretty tempted to remove the bold "Completions" header as well, so you just have a "Word Completion" section and a "Command Completion" section.
sounds right (David's suggestion plus Calum's feeback). I expect we could use the new gtk file chooser for this, i.e. launch the file chooser with the 'add' button. It'd be nice (but perhaps not required) if we checked the file once it's added, to make sure it's readable and appears to contain a word list. This needs to be completed by the feature freeze (12 Jan).
Created attachment 21986 [details] second design iteration
Created attachment 21987 [details] this one with stock buttons
ok: it would be nice if the add/remove, additional word list checkbutton, and table were all somehow grouped visually together in the dialog. It takes a little looking to figure out for certain that the table is for the auxiliary word list (only). also - why two columns?
No reason for the two columns (I haven't modified the default).
bumping up prio since this feature is targeted for gnome 2.6 (feature freeze Jan 12). This feature impacts internationalization.
David, this one needs implementation this week. Can you do it?
This got backlogged when I moved from RH to SuSE. I can make this a priority and I can/will fit it in for this week.
Created attachment 23169 [details] [review] proposed patch
Note: I've broken the API freeze with this patch. Also, I have implemented this version of the UI from scratch (don't ask). It provides the UI to specify one extra word list file. I have made it easy to add more, but I am concerned about tidying up other UI/features too. It uses a GnomeFileEntry... I hope that's okay until there is a GTK one? TODO: hook up to word completion list internal model. test extra word list file format and warn user if bad.
David: the API issue is OK since GOK doesn't provide any 'platform' libraries. Thanks for doing this. GnomeFileEntry? But there's a gtk one now! (in gtk+ 2.3 and above) Can you check on the GtkFileSelector in current gtk+ (we already have a dependency on gtk+ 2.3.X anyhow) and see if we can't use that instead? I don't think any new 2.6-bound code should be using GnomeFileEntry.
I don't see a GtkFileSelector... I do see a GtkFileSelection, which I think is just a dialog. I would be pretty straight forward to roll my own GtkEntry + button + GtkFileSelection combination I guess... What do you think? Is there a GTK version of the very handy GnomeFileEntry widget?
gtk+/gtk/gtkfilesel.h It is a dialog. I didn't get that you wanted to do this via some kind of file-combobox thingy. What lib is GnomeFileEntry in ? I don't see a lot of use of it grepping cvs. But maybe it's fine if it's in libgnome or something, not sure. Go ahead and put it in I guess, then ping Calum for HIG advice on it; we could change on the basis of UI review feedback before the 'Hard UI Freeze' which is a couple weeks away.
Found it in libgnomeui: http://cvs.gnome.org/bonsai/cvsblame.cgi?file=libgnomeui%2Flibgnomeui/gnome-file-entry.c&rev=&root=/cvs/gnome So, I'll submit the patch I guess and ping Calum.
before I forget: have a look at GtkFileChooser, that might be what we want here.
It appears to be a dialog (a replacement for GtkFileSelection). I've committed the patch as is to head. Calum, can you take a look at the UI and advise? It is on the gok preferences notebook on the Prediction page (gok --settings). If need be, I should be able to move to a pure Gtk version later without any visual changes.
Note I accidentally committed a bad version of gok-page-wordcomplete.c ( and will correct this shortly)
I'm in the middle of re-building GNOME from scratch, so I'll take a look as soon as it's gotten around to rebuilding GOK...
closing this bug since an implementation is now in cvs. however we ought to remember that reviewing this UI should be part of the HIG review process for GOK.
The UI for adding a single extra word list (as now in CVS) looks fine to me, except to say that the horizontal separator probably isn't really necessary-- a bit of blank space would do the job just as well with less clutter. But I'm not overly fussed about that, and unless you're planning to get a multiple-lists version in before hard UI freeze on Feb 9th, I don't think there's any need for any further UI review on this particular feature. (I'll try and give the rest of the app a quick once over this week for any other minor issues, though.)