After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 125571 - Open Recent menu contains 'trash:'
Open Recent menu contains 'trash:'
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 128928 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-10-27 06:09 UTC by Dennis Cranston
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch to fix this bug. (1.68 KB, patch)
2003-12-10 17:38 UTC, Dennis Cranston
none Details | Review
Updated proposed patch. (1.91 KB, patch)
2003-12-11 15:34 UTC, Dennis Cranston
none Details | Review
New proposed patch. (1.54 KB, patch)
2003-12-15 18:09 UTC, Dennis Cranston
none Details | Review

Description Dennis Cranston 2003-10-27 06:09:12 UTC
The summary pretty much says it all.  'Trash:' should not be in the 'Open
Recent' menu.
Comment 1 Vincent Untz 2003-10-28 17:02:38 UTC
Dennis: I suppose you opened the trash by clicking on the desktop. If
so, I think it's Nautilus that adds the trash to the recent files. So
the bug should be moved there, I suppose. Can you confirm this is what
you did?
Comment 2 Arvind S N 2003-10-31 04:17:14 UTC
cc'ing James
Comment 3 James Willcox 2003-10-31 17:50:45 UTC
Vincent: You are probably right.  Though I don't see why it would do that.
Comment 4 Vincent Untz 2003-11-05 16:10:40 UTC
Moving to nautilus. Dennis: can you reproduce the bug?
Comment 5 Dennis Cranston 2003-11-05 17:13:18 UTC
Unfortunately, I haven't been able to nail down this problem to a
fixed set of steps.  It is probably nautilus adding 'trash:' to the
open recent list, but I can't verify it.
Comment 6 Martin Wehner 2003-12-10 03:28:08 UTC
*** Bug 128928 has been marked as a duplicate of this bug. ***
Comment 7 Dennis Cranston 2003-12-10 17:38:59 UTC
Created attachment 22295 [details] [review]
Proposed patch to fix this bug.
Comment 8 Dennis Cranston 2003-12-10 17:42:51 UTC
I just attached a proposed patch.  Turns out that nautilus is not
filtering out trash uris.  Also, I added a filter for x-directory
mime-types.  This fixes things like samba shares from being added.
Comment 9 Dennis Cranston 2003-12-11 15:34:14 UTC
Created attachment 22338 [details] [review]
Updated proposed patch.
Comment 10 Alexander Larsson 2003-12-15 15:18:10 UTC
Use nautilus_file_is_directory instead of the mime thing.
Comment 11 Dennis Cranston 2003-12-15 18:08:48 UTC
I am attaching a new proposed patch with the changes you recommended.
 Thanks.
Comment 12 Dennis Cranston 2003-12-15 18:09:42 UTC
Created attachment 22468 [details] [review]
New proposed patch.
Comment 13 Alexander Larsson 2003-12-15 18:45:52 UTC
The g_free needs to go outside the if block, otherwise looks fine to
commit (assuming you tested it and it worked).
Comment 14 Dennis Cranston 2003-12-15 21:54:58 UTC
Moving the g_free() outside the if statement is wrong.  
You'll cause a compile error, "fm-directory-view.c:5947: warning:
`file_uri' might be used uninitialized in this function".  The code
has been tested and works, so I checked it in to CVS head.

2003-12-15  Dennis Cranston <dennis_cranston at yahoo com>

 * src/file-manager/fm-directory-view.c:  Do not add trash and
 directory uris to the recent documents list. Fixes bug #125571.