After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 125177 - option for disabling library update?
option for disabling library update?
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
HEAD
Other Linux
: Normal major
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 120259 123894 124830 126849 127911 129798 140753 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-10-22 05:51 UTC by Elliot Peele
Modified: 2006-03-12 11:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.32 KB, patch)
2006-03-05 10:25 UTC, James "Doc" Livingston
committed Details | Review

Description Elliot Peele 2003-10-22 05:51:01 UTC
It would be nice if there was an option to not scan the hard drive every
time rhythmbox starts. This tends to take a long time on a resonable amount
of oggs (~7GB) and on a laptop hard drive. This could either be implimented
as a gconf key or in the preferences, I'm not real picky.
Comment 1 Colin Walters 2003-10-22 14:03:18 UTC
Let's admit it - Rhythmbox is just broken.  It shouldn't needlessly
scan your hard disk on start up.  

The way to fix this is to cache the mtime not just of the files, but
also of the directories they're in.  That way if nothing has changed,
we just do a few stats and we're done.
Comment 2 Colin Walters 2003-11-12 05:46:50 UTC
*** Bug 124830 has been marked as a duplicate of this bug. ***
Comment 3 Colin Walters 2003-11-12 05:52:47 UTC
*** Bug 123894 has been marked as a duplicate of this bug. ***
Comment 4 Colin Walters 2003-11-12 22:28:09 UTC
*** Bug 126849 has been marked as a duplicate of this bug. ***
Comment 5 Colin Walters 2003-11-18 07:50:56 UTC
*** Bug 120259 has been marked as a duplicate of this bug. ***
Comment 6 Colin Walters 2003-12-04 02:10:09 UTC
*** Bug 127911 has been marked as a duplicate of this bug. ***
Comment 7 Colin Walters 2003-12-21 22:47:21 UTC
*** Bug 129798 has been marked as a duplicate of this bug. ***
Comment 8 Colin Walters 2004-04-21 20:38:56 UTC
*** Bug 140753 has been marked as a duplicate of this bug. ***
Comment 9 Nick Dimiduk 2004-04-21 22:35:39 UTC
Could famd be used to notify rb of a filesystem update like it does for
nautilus?  That way, it happens automagically for the user.
Comment 10 Colin Walters 2004-04-21 23:45:53 UTC
Yep, and there is a start at that implemented in
rhythmbox-devel@gnome.org--2004/rhythmbox--main--0.9.  But it needs more work...
Comment 11 Colin Walters 2004-09-21 14:45:17 UTC
Well, we use file monitoring now.  But actually my original plan for
automatically updating the library based on the toplevel directory mtime
wouldn't work.  So we do need to scan all the folders on startup still.
Comment 12 Colin Walters 2004-09-21 21:40:41 UTC
Renaming this one since file monitoring is done.

We need to think about whether a preference for not using file monitoring and
library updating on startup is necessary.  
Comment 13 Loïc Minier 2005-10-07 11:15:38 UTC
/!\ the top level mtime doesn't change if files are added to a sub directory. 
only the mtime of the holding directory changes.
Comment 14 James "Doc" Livingston 2005-10-24 04:26:25 UTC
Also, the mtime of a directory doesn't change when one of the files does, only
when files are added or removed. This means that to check for changed files, we
have to look at the mtime of every file.
Comment 15 James "Doc" Livingston 2006-03-05 10:25:04 UTC
Created attachment 60685 [details] [review]
patch

We already have a "--no-update" command line option, it just wasn't getting checked. This patch make RhythmDB look at the option and not stat files if it is set.

I'm not sure about the wording of the description of the command-line option.
Comment 16 James "Doc" Livingston 2006-03-12 11:38:41 UTC
I've committed the patch to cvs. You can now tell RB not to check for updated files by passing --no-update.