GNOME Bugzilla – Bug 123986
Use stock Icons in the bookmark menu items
Last modified: 2004-12-22 21:47:04 UTC
The icons for menu items in gconf-editor do not follow the /desktop/gnome/interface/menus_have_icons gconf key until the key is changed, so that, for example, if you do not change the value of the key, icons will be shown no matter what the key says. Slightly worse, the icons in the bookmark menu items do not follow the gconf key at all. Follows a patch which fixes this. This adds a little duplication between gconf-bookmarks.c and gcon-editor-window.c, but it's good, IMO, because it keeps the two files as separate as they are now.
Created attachment 20519 [details] [review] Make menu icons follow menus_have_icons preference key
Created attachment 24969 [details] [review] Icons in the bookmark menu items now follow the gconf key
This can be done without the port to gnome, but it will more cosistent if we wait until gconf be a gnome app
Thanks to all of you guys! I've applied Mariano patch, but not the one from Sujay and Varaharaj because I'm not happy about setting GTK_STOCK_UNDELETE for the edit bookmarks entry. I cannot find any good stock icon for it. Maybe we can left it without icon, or add a custom one. Changing description until we find a solution for this.
Comment on attachment 24969 [details] [review] Icons in the bookmark menu items now follow the gconf key Marking as needs-work until we find a good icon
I believe there is a stock edit bookmarks as part of the f.d.o hicolor theme. Perhaps you can use that?
yep, I also found gpdf and epiphany versions. We can copy and use any bluecurve art that doesn't include Bluecurve name or redhat logos, cannot we?
I believe that's the correct case * * (of course that's my understanding I obviously don't speak for RH or RH legal)
The hicolor icon theme has several bookmark icons. stock_bookmark, stock_edit-bookmark, stock_delete-bookmark, and stock_add-bookmark http://freedesktop.org/Software/icon-theme The license for these is much more obvious.
Done, thanks