GNOME Bugzilla – Bug 122703
Print manager crashes when a file in /bin is selected for icon
Last modified: 2005-09-21 10:15:55 UTC
1. Print manager crashes 1. Open print manager Applications -> System Tools -> Print Manager 2. Right-click on a printer icon and select "Properties" 3. Select "Browse" button to select an icon for the printer 4. Select any file in /bin directory, Say "ControlPanel" Result: Print manager crashes Expected output: Print manager should not crash. Print manager should display a message on selecting a file of improper format.
Created attachment 20079 [details] [review] This patch fixes the bug.
High for patch and new keywords. Is anyone (Sun?) using the GNOMEVER2.2 stuff still?
Kjartan Maraas: Sorry for the late response :), we are using GNOME 2.2 for JDS.
It doesn't crash here with Linux. Is this crash Solaris specific? How does testing to make sure it's not a directory help really? Please explain further. I just get a warning that the image is corrupt etc.
Vijaykumar? Still there?
Kjartan: This crash is only seen on solaris, AFAIK, When a /bin is entered in text entry and ok is pressed in properties dialog , printer_properties_response_cb is called, which passes /bin gdk_pixbuf_new_from_file() function, were there is every possibility that header data accidentally matches with that of vaild image files. The header of /bin matches with the header of some image file, further, function get_contiguous_pixbuf() is called where floating point error occures, because of 'division by zero', which leads to the crash. So a check was made to make sure that symlink passed is not a directory.
Commiting this. Thanks.