GNOME Bugzilla – Bug 122367
Implement "All tracks by same artist?" checkbox
Last modified: 2008-01-21 10:10:29 UTC
Hi, Well a patch I previously sent which made the artist edit change all the artists is often convenient, but sometimes (for instance when you have a mix CD with no disk artist from musicbrainz) it just gets in the way. You want to set the album artist, but not the track artists. This checkbox controls the behaviour. It adds a new checkbox next to the artist entry.
Created attachment 19958 [details] [review] Patch. Don't worry about the size of the glade changes, I only added one widget, but glade seems to like reordering things for no good reason.
Oh, I should mention that I added myself to the authors list. I think I've done enough patches and micro-bugfix/patchlets by now for it, but if you disagree feel free to remove that line, I'm not bothered ;)
Adding the PATCH keyword and upgrading the priority level to High due to the attached patch.
FWIW, this doesn't apply to HEAD for me, Mike. And i'd love to use it. :)
*** Bug 152066 has been marked as a duplicate of this bug. ***
Created attachment 36879 [details] [review] Patch against CVSHEAD Changes Done: 1. When the 'All Tracks by the same Artist' check box is OFF, then make the Artist column Editable, else make it UnEditable 2. When the 'All Tracks by the same Artist' check box is toggled ON, then change all the entry in the Artist Column to that pointed by the Artist Text Entry. 3. While extracting, make the 'All Tracks by the same Artist' check box insensitive.
I'm still not sure if this is a good idea...
So, basically, not having this or something like it makes s-j a pain for mix CDs, soundtrack CDs, and DJ'd CDs with different contributors. I'd love to do it 'automatically' somehow... hrm. (thinking cap on) So, the problem (at least for me, and maybe this matches the experience of Mike, Alexander, and others) is when there are a lot of different track musicians. Maybe the right solution here is to test and see if all the track musicians are the same, and if that is the case, then just go ahead and apply, and if the musicians are not all the same, then pop up a 'apply this change to all tracks? [cancel][apply]' dialog?
I should have explained more. http://bugzilla.gnome.org/show_bug.cgi?id=165323 presents an alternative model which I am leaning towards at the moment on the grounds that it doesn't involve yet another widget. I'm still recovering from adding a genre widget... :)
The proposal in bug 165323 doesn't solve the case[1] where musicbrainz correctly gives track artists (and so they are unmodified) but gives really wacky crap for the artist field. [1] I just ripped a series of four mix CDs, all from the same DJ and in the same series, and all four had a different author listed. The per-track settings were fine :/
Okay, I think I want this in 2.16. Anyone willing to update the patch to cvs HEAD?
Created attachment 75309 [details] [review] Updated to apply to cvs head I've updated this to work with the latest cvs head. Again, glade does some strange reordering...
Created attachment 75328 [details] [review] Like the last patch, but I removed an unused variable
Created attachment 101963 [details] [review] Only change track artist if it was the same as the album artist already The patch checks to see if the track artist matches the former album artist before changing it. Otherwise it leaves it alone. This may not be the optimal solution, but it makes SJ work the way I expect it to work. It also works against bugs 157814 and 397412.
Committed Bill's patch to SVN. I think this is a good solution, but please re-open if anyone has a good counter-argument.
*** Bug 397412 has been marked as a duplicate of this bug. ***