GNOME Bugzilla – Bug 121491
--title <locale string> needs conversion to UTF-8
Last modified: 2007-01-25 17:53:16 UTC
When gnome-terminal is run with --title option, the following string argument is formatted in locale's native encoding, so should be converted to UTF-8.
Created attachment 19744 [details] [review] A proposed patch to convert given --title string to UTF-8.
This patch does half the work: terminal_app_get_clone_command should undo the conversion into utf-8, as its output will go through the option parsing routine eventually. While we are at it, shouldn't we do this for other options too? At least --working-directory and --{window,tab}-with-profile come to mind. Looking at gnome-terminal --help output, those are the ones taking textual input... I don't know about the argument to --execute.
Hidetoshi? Could you update the patch according to comment #2?
Created attachment 57876 [details] [review] updated patch This patch will convert all text input parameters to UTF-8 and when cloning the arguments will undo the convertion for those parameteres where it makes sense (title and working-directory).
Happy birthday, dear patch. :-)
Doesn't GOption convert to UTF-8 automatically? This should be marked as a dupe of "Use GOption" bug for g-t.
Indeed. We don't have any G_OPTION_FLAG_FILENAME so everything gets utf8ised. I had meant to mark this as a dup a while ago but forgot about it :/ *** This bug has been marked as a duplicate of 336155 ***