GNOME Bugzilla – Bug 118991
Some usability improvements
Last modified: 2010-01-24 01:06:23 UTC
Here are some changes I would make, feel free to use what you like: + Default Colors: Processor-colors: #0060a0 (system), #0090ff (user), #600000 (nice) Memory-colors: #ffa000 (user+shared), #ffff00 (buffers), #00ff00 (cached), #00a000 (free) + Borders: The applet is considerably smaller than the window list applet and the extra black and gray frame take away space that could be used by the graph. (Every pixel counts) + If you hover over the graphs, and keep still when it says 100%, watch the tooltip frame break (the right corners) when the content changes. This happens both when shrinking and growing.
I now also noticed that the CPU statistics never get to 100%, it's always 1 pixel idle. And I'm afraid that the way the rounding is done, free memory will always be at least 1 pixel too. With about 18 pixels (on a X-Small panel) 1 pixel is already 5.5%. That's why the tooltip always says either 95% or 100%.
Any work done on this?
The third issue WORKSFORME. The second issue there already seems to be some code support for -- all you need to do to get rid of the border is: diff -u -p -r1.48 load-graph.c --- load-graph.c 12 Jan 2005 18:21:22 -0000 1.48 +++ load-graph.c 21 Mar 2005 22:08:15 -0000 @@ -279,7 +279,7 @@ load_graph_new (PanelApplet *applet, gui g->size = MAX (size, 10); g->pixel_size = panel_applet_get_size (applet); g->tooltip_update = FALSE; - g->show_frame = TRUE; + g->show_frame = FALSE; g->applet = applet; g->main_widget = gtk_vbox_new (FALSE, FALSE);
Created attachment 39281 [details] [review] Fixes drawing ("never get to 100%") Drawing was done so that it always started one pixel outside of the pixmap. I hope it still applies (no net at home atm makes it hard to upd. my build env.)
Default Colors: I dunno about the suggested colors. I remember testing it out a while back and didn't like it. I personally think what we have atm. is good. It's hard to differentiate between e.g. User, System and Nice in the processor monitor but I think that's the way it should be. Most people (ordinary users) don't care or even know what the difference is. They just want to know if their CPU is doing some work. Let the geeks modify the colors to diverge more if they want to. :) Borders: I tested removing the borders but didn't like it. Some space is needed to separate the different elements from each other. That's just one mans opinion though. MAINTAINERs, please advice. Tool tip frame break: Unable to reproduce. Tool tip always says either 95% or 100%: I guess the right way to fix this one is to pass a char **tooltip_str to the Get*() functions and have the value calculated for the tooltip be more exact than what's placed in data[] (which really is the number of pixels to plot, not %). MAINTAINERs, please advice.
Benoit, have you looked at this patch?
Sorry, i'm not able to test it, but i did and it was fine iirc.
Here are 3 attachements. The first is how it is now, the second is a little stretched so it is the same size as the window list applet and the third is without the additional borders. This is a 4 pixel improvement (from 18 to 22).
Created attachment 50334 [details] Original sysmon applet looks
Created attachment 50335 [details] Stretched to the same size as the Window List applet
Created attachment 50336 [details] Border removed too, 4 pixel (20%) gain on prev. 18 pixels
Is there any reason why the patch hasn't been applied yet? I just tested it with an up-to-date CVS and it works fine. It isn't blocking by any freeze is it? It fixes two quite obvious and common drawing mistakes: * bottom of h pixels high bitmap is (h-1) not h (the "g->pos [i] = g->draw_height - 1;" fix) * h pixels high line should be drawn from y to y+h-1 not y+h (the gdk_draw_line () fix) and also, only do any drawing if height isn't 0. Sorry for stating the obvious. :)
2005-08-20 Davyd Madeley <davyd@madeley.id.au> * multiload/load-graph.c: Drawing was done so that it always started one pixel outside of the pixmap. Part of bug #118991. Patch from Martin Ejdestig <mejde@dtek.chalmers.se>.
Not a GNOME release showstopper, removing that mark.
Closing this.